EZLog icon indicating copy to clipboard operation
EZLog copied to clipboard

Support for TimeZone

Open lazywinadmin opened this issue 8 years ago • 5 comments

Great module Arnaud!

Would it be possible to add support for TimeZone OR Set the time to UTC/GMT by default. This becomes very helpful when you compare logs coming from different machines located in different parts of the world.

Let me know your thoughts.

I was thinking to contribute to your module initially but I'm not sure if this will break the current usages that users are making of it.

lazywinadmin avatar Nov 24 '16 18:11 lazywinadmin

Thanks FX!

That's a good suggestion. I'll definitely address this need. Don't hesitate to send a pull request if you want to contribute, your contributions are welcome!

apetitjean avatar Nov 24 '16 18:11 apetitjean

It could be implemented as a switch passed with the header. I'm thinking of a switch like "-UTC". What do you think about it?

apetitjean avatar Nov 24 '16 18:11 apetitjean

That could be one solution however you won't know which parameter was used when looking at the log.

So I'm thinking, this should be included in the metadata of the log. This way, if you ever need to parse multiple logs you can pre-check all the logs use the same timezone. What do you think ?

I'll propose something in a PR, feel free to comment/reject.

lazywinadmin avatar Nov 24 '16 22:11 lazywinadmin

This is the next item on my to list. ;-) I will - as you suggested - update the metadata section to add this info. This way it will be easily understandable by ConvertFrom-EzLog.

apetitjean avatar Feb 03 '17 15:02 apetitjean