accessible-autocomplete icon indicating copy to clipboard operation
accessible-autocomplete copied to clipboard

Published 20 hours ago • verified publisher icon alphagov

Issue 157: trigger `onConfirm` after set state

Open samtsai opened this issue 8 years ago • 5 comments

onConfirm is currently triggered before setState is called, to keep proper state with what is sent to onConfirm, setState should be called then onConfirm.

This is to resolve #157

samtsai avatar Jun 14 '17 17:06 samtsai

Have some linting errors, let me fix

samtsai avatar Jun 14 '17 18:06 samtsai

See comment, looks good otherwise. 👍

tvararu avatar Jun 15 '17 09:06 tvararu

Should this be documented somewhere?

Edit: Actually, I've reread it this does not introduce anything new. 👍

NickColley avatar Aug 29 '17 09:08 NickColley

Any update on this? Thanks!

tedw avatar Feb 22 '19 19:02 tedw

I've rebased this one with main to help us review

colinrotherham avatar Jan 17 '24 13:01 colinrotherham