react-native-skeleton-content icon indicating copy to clipboard operation
react-native-skeleton-content copied to clipboard

Dependencies versions upgrade for Expo SDK 44

Open MonsieurBuffle opened this issue 3 years ago • 15 comments

Upgrading expo projects to expo SDK 44 added some changes in dependencies versions :

  • expo-linear-gradient : 10.0.3 => 11.0.0
  • react-native-reanimated : 2.2.0 => 2.3.1

This induced some conflicts because of required dependencies of react-native-skeleton-content 1.0.24.

Is it possible to bump versions of these dependencies in a newer version of the package ? That would be great :)

MonsieurBuffle avatar Dec 18 '21 17:12 MonsieurBuffle

Is there a workaround for this until you push a fix?

caelinsutch avatar Jan 01 '22 07:01 caelinsutch

any news on this?

alekseytsvetkov avatar Jan 04 '22 11:01 alekseytsvetkov

Do we have any news on this?

CharisMytilinaios avatar Jan 06 '22 17:01 CharisMytilinaios

Indeed! I was upgrading from Expo 41 and after unimodules, got this error.

robertoosantos avatar Jan 13 '22 13:01 robertoosantos

While this problem is not solved in the official repository I forked it to solve this problem with sdk 44 https://www.npmjs.com/package/@vitu.soares/react-native-skeleton-content

victorsoares96 avatar Jan 16 '22 20:01 victorsoares96

@alexZajac have you had a chance to take a look at this issue? Seems like a quick simple fix.

rbq10 avatar Feb 15 '22 21:02 rbq10

I tried to do it by myself and propose a fix, but without success. I'll try to dive in more, but I don't know when I'll have time to do so, sorry for that.

Note/Reminder : By the way, I'm using react-navigation in my expo project which, in the expo SDK44 context, also bring expo-linear-gradient incompatibility.

MonsieurBuffle avatar Mar 02 '22 10:03 MonsieurBuffle

While this problem is not solved in the official repository I forked it to solve this problem with sdk 44 https://www.npmjs.com/package/@vitu.soares/react-native-skeleton-content

@victorsoares96 How do I install your package?

ataravati avatar Apr 15 '22 20:04 ataravati

+1 Love the library, a fix for this would be great!

mtourj avatar Apr 21 '22 20:04 mtourj

+1 this is def the best skeleton loader out there! Would love a fix for this. Thanks so much!

jeff-polls avatar Apr 28 '22 23:04 jeff-polls

+1 Looking forward for a fix and using this package

ansmlc avatar May 02 '22 03:05 ansmlc

While this problem is not solved in the official repository I forked it to solve this problem with sdk 44 https://www.npmjs.com/package/@vitu.soares/react-native-skeleton-content

Tried this and got the error: Error: Requiring module "node_modules\react-native-reanimated\lib\Animated.js", which threw an exception: Error: Reanimated 2 failed to create a worklet, maybe you forgot to add Reanimated's babel plugin?

ansmlc avatar May 02 '22 03:05 ansmlc

@ansmlc did you add reanimated plugin to your babel config? Follow the steps here: https://docs.expo.dev/versions/latest/sdk/reanimated/

jeff-polls avatar May 02 '22 15:05 jeff-polls

@ansmlc did you add reanimated plugin to your babel config? Follow the steps here: https://docs.expo.dev/versions/latest/sdk/reanimated/

That worked. Thanks!

ansmlc avatar May 03 '22 04:05 ansmlc

@ansmlc did you add reanimated plugin to your babel config? Follow the steps here: https://docs.expo.dev/versions/latest/sdk/reanimated/

@jeff-polls @victorsoares96 Another issue with this package... Any idea what this is about?

./node_modules/@vitu.soares/react-native-skeleton-content/lib/SkeletonContent.js 265:67
Module parse failed: Unexpected token (265:67)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders

|         return transform;
|     };
>     const getBoneContainer = (layoutStyle, childrenBones, key) => (<react_native_1.View key={layoutStyle.key || key} style={layoutStyle}>
|       {childrenBones}
|     </react_native_1.View>);

ansmlc avatar May 11 '22 19:05 ansmlc

Thanks gor this great package, but this bug killing us, please publish a fix for this.

y3n3rrr avatar Sep 05 '22 14:09 y3n3rrr

@victorsoares96 could you write a PR to solve this? Would love to have your contribution enabling Expo 44!

alexZajac avatar Sep 05 '22 23:09 alexZajac

@alexZajac surely! in this week I will be make this, thank's!

victorsoares96 avatar Sep 06 '22 12:09 victorsoares96

While this problem is not solved in the official repository I forked it to solve this problem with sdk 44 https://www.npmjs.com/package/@vitu.soares/react-native-skeleton-content

@victorsoares96 How do I install your package?

npm i @vitu.soares/react-native-skeleton-content

victorsoares96 avatar Sep 11 '22 13:09 victorsoares96