eth95 icon indicating copy to clipboard operation
eth95 copied to clipboard

abi-decoder's GPL-3.0 license is not compatible with eth95's MIT license

Open lukaw3d opened this issue 1 year ago • 3 comments

https://github.com/adrianmcli/eth95/blob/032256b867d1ed297482d7e6254d7f83d0fe8022/package.json#L10

https://github.com/adrianmcli/eth95/blob/032256b867d1ed297482d7e6254d7f83d0fe8022/package.json#L49

https://www.npmjs.com/package/abi-decoder

GPL-3.0

lukaw3d avatar Apr 19 '24 03:04 lukaw3d

Hmmm, that sucks. What do you suggest we do?

Should we remove the abi-decoder dependency? I think Wagmi/Viem has a good option now right? They are MIT licensed.

adrianmcli avatar Apr 19 '24 05:04 adrianmcli

Simplest is probably remove dependency and do something like

const contractInterface = new ethers.utils.Interface(selectedContract.abi)
receipt.logs.forEach((log) => {
  const evt = contractInterface.parseLog(log)
  const values = evt.args.map(arg => arg.toString())
})

lukaw3d avatar Apr 19 '24 14:04 lukaw3d

Simplest is probably remove dependency and do something like

const contractInterface = new ethers.utils.Interface(selectedContract.abi)
receipt.logs.forEach((log) => {
  const evt = contractInterface.parseLog(log)
  const values = evt.args.map(arg => arg.toString())
})

happy to take a PR for this!

adrianmcli avatar Apr 19 '24 17:04 adrianmcli