Vim icon indicating copy to clipboard operation
Vim copied to clipboard

fixes #7670: support `put =`

Open elazarcoh opened this issue 3 years ago • 6 comments

What this PR does / why we need it: Allow expressions in put command. Implemented range(start, stop, step=1). example: :put=range(10,5,-1)

Which issue(s) this PR fixes fixes #7670

Special notes for your reviewer:

elazarcoh avatar Aug 09 '22 11:08 elazarcoh

This also set up groundwork for #7136

elazarcoh avatar Aug 09 '22 11:08 elazarcoh

This also set up groundwork for https://github.com/VSCodeVim/Vim/issues/7136

I've got a branch I haven't touched for like a year with some decent progress on expression parsing & evaluating. I'll try to get it to a MVP state and push - then we can hook it up to this. Let me know if you'd be interested in working off that branch, also.

J-Fields avatar Aug 21 '22 16:08 J-Fields

This also set up groundwork for #7136

I've got a branch I haven't touched for like a year with some decent progress on expression parsing & evaluating. I'll try to get it to a MVP state and push - then we can hook it up to this. Let me know if you'd be interested in working off that branch, also.

I think it would be wise to start off somewhere, your branch might be a good place for it, as I'm sure how it would be best to design the code anyway.

elazarcoh avatar Aug 21 '22 16:08 elazarcoh

See #7920

J-Fields avatar Aug 22 '22 04:08 J-Fields

See #7920

This is much more comprehensive. What will be a good way for me to contribute for this PR? What is still needed for it to be ready?

elazarcoh avatar Aug 22 '22 07:08 elazarcoh

This is much more comprehensive.

Yeah I got further along than I'd remembered, actually

What will be a good way for me to contribute for this PR? What is still needed for it to be ready?

I'd like to get some more polish on it before releasing it, but probably not too much more needs to be done before it's merge-worthy. I think sometime this week I'll release v1.23.3, then merge #7920. At that point, we can re-group and see what the best path forward is.

We can target #7920, this MR, and #7893 for 1.24.0. Pretty exciting stuff!

J-Fields avatar Aug 22 '22 16:08 J-Fields

Thanks @elazarcoh!

J-Fields avatar Mar 27 '23 04:03 J-Fields