Vim icon indicating copy to clipboard operation
Vim copied to clipboard

Published 20 hours ago • verified publisher icon VSCodeVim

Fix `set tw=N`

Open adamjhawley opened this issue 3 years ago • 3 comments

  • Fixes set tw=N command
  • Add test for set tw=N

What this PR does / why we need it: Since the v1.23.0 release, setting 'textwidth' on the fly with set tw=100 has been broken and would cause the following error:

CommandLine: Error executing cmd=set textwidth=100.
err=TypeError: Cannot set property textwidth of #<f> which has only a getter.

This PR provides a fix and also adds a test so we can tell if the command breaks again.

Which issue(s) this PR fixes Fixes #7809

adamjhawley avatar Jul 01 '22 23:07 adamjhawley

(Sorry, didn't mean to close this PR temporarily.)

I've come up with something for set textwidth(number) but I'm not sure it is the right approach so very open to alternative suggestions! This PR is now more of an RFC.

adamjhawley avatar Sep 03 '22 21:09 adamjhawley

It'd be nice if this worked! Can this be rebased and landed?

tamird avatar May 17 '23 16:05 tamird

@J-Fields Would you be willing to take a look at this one? Having this will be a pretty big impact on usability. Thanks!

edgimar avatar May 10 '24 02:05 edgimar