svelte-materialify icon indicating copy to clipboard operation
svelte-materialify copied to clipboard

feat(FluidGrid): implement material-ui inspired grid

Open betaboon opened this issue 4 years ago • 7 comments

first of thanks for this great package.

I added a grid that is inspired by reacts material-ui.

betaboon avatar Feb 02 '21 00:02 betaboon

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/thecomputerm/svelte-materialify/arhniw0fc
✅ Preview: https://svelte-materialify-git-fork-betaboon-feature-fluidgrid.thecomputerm.vercel.app

vercel[bot] avatar Feb 02 '21 00:02 vercel[bot]

(unofficial reviewer here, says code+feature is good)

Florian-Schoenherr avatar Feb 02 '21 06:02 Florian-Schoenherr

Can you specify the difference between FluidGrid and the other Grid system in the description?

TheComputerM avatar Feb 02 '21 10:02 TheComputerM

Can you specify the difference between FluidGrid and the other Grid system in the description?

Yes. the documentation has to be fleshed out some more. I wanted to get feedback on the feature as such before putting the time in for that first :)

betaboon avatar Feb 02 '21 11:02 betaboon

marked this PR as draft until I'm done :)

betaboon avatar Feb 02 '21 22:02 betaboon

i just pushed a separate commit that removes the requirement of using global for the style. I would very much like to get feedback on the approach chosen.

betaboon avatar Feb 03 '21 00:02 betaboon

any update on this PR ?

nateshmbhat avatar Apr 01 '21 00:04 nateshmbhat