jsonschema-rs icon indicating copy to clipboard operation
jsonschema-rs copied to clipboard

Published 20 hours ago • verified publisher icon Stranger6667

Improve resolving

Open Stranger6667 opened this issue 3 years ago • 1 comments

Stranger6667 avatar May 27 '22 21:05 Stranger6667

Codecov Report

Merging #375 (12f9b6b) into master (bfe69d3) will increase coverage by 18.25%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #375       +/-   ##
===========================================
+ Coverage   64.35%   82.61%   +18.25%     
===========================================
  Files          57       57               
  Lines        7814     5555     -2259     
===========================================
- Hits         5029     4589      -440     
+ Misses       2785      966     -1819
Impacted Files Coverage Δ
jsonschema/src/resolver.rs 90.00% <100.00%> (+3.04%) :arrow_up:
jsonschema/src/lib.rs 81.08% <0.00%> (+59.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bfe69d3...12f9b6b. Read the comment docs.

codecov[bot] avatar May 27 '22 21:05 codecov[bot]

This implementation is actually slower because the exploration stack lives on the heap. Though, it might be better to use the program stack instead - it might be faster (as unrolling multiple levels manually actually gives a lot in performance)

Stranger6667 avatar Oct 26 '22 13:10 Stranger6667