libsodium_dart_bindings icon indicating copy to clipboard operation
libsodium_dart_bindings copied to clipboard

Published 20 hours ago • verified publisher icon Skycoder42

feat: Implement Ed25519 to Curve25519

Open f-person opened this issue 2 years ago • 7 comments

See https://libsodium.gitbook.io/doc/advanced/ed25519-curve25519

f-person avatar Jun 30 '23 22:06 f-person

Thank you for the PR. I will try to review it within the next few days!

Skycoder42 avatar Jul 04 '23 05:07 Skycoder42

The tests are mostly copied from other methods in SignSumo and modified to fit. I wonder if it would be better to refactor them in a way to share the code or if it's fine the way it is :)

f-person avatar Jul 04 '23 09:07 f-person

Hi! Somehow I missed your reply and only noticed it when configuring a shortcut(?) in the GitHub mobile app :D

Thanks for the review! I'll take a look soon and fix the code! Have a lovely day!

f-person avatar Jul 28 '23 21:07 f-person

Hi @f-person. I wanted to ask if you need any help with the PR?

Skycoder42 avatar Sep 13 '23 05:09 Skycoder42

Hi, Felix! Unfortunately, I lost interest in the project for which I needed this function implemented and have been busy recently. "Allow edits by maintainers" is enabled, so feel free to edit or close the PR; both are fine by me :).

f-person avatar Sep 13 '23 07:09 f-person

@Skycoder42 are you working on this PR? If not I can try to find some time to help.

rhbrunetto avatar Sep 26 '23 16:09 rhbrunetto

@rhbrunetto No, I am currently not actively working on it. Feel free to continue the PR!

Skycoder42 avatar Oct 04 '23 15:10 Skycoder42