pipedream icon indicating copy to clipboard operation
pipedream copied to clipboard

[BUG] Github - Create a Pull Request async options fails to load

Open ctrlaltdylan opened this issue 3 years ago • 5 comments

Describe the bug

Any Github source using async options to populate props is infinitely loading when attempting to search:

https://share.descript.com/view/NGTVLNu161n

Reproduction steps

  1. Create a new workflow
  2. Create a Github New Pull Request (Instant) trigger
  3. Connect your Github account
  4. Attempt to search in the Repository prop
  5. See infinite load

Expected behavior I expect async options to work properly.

Additional context

  1. This issue seems to be happening with Bitbucket as well, not sure if it's an underlying system or devops problem.

  2. The code for this New Pull Request (Instant) source is missing from the github component in the registry it seems.

ctrlaltdylan avatar Jul 22 '22 10:07 ctrlaltdylan

@ctrlaltdylan It's working correctly for me. Is this happening just with one user, or are there more reports about it?

vellames avatar Jul 22 '22 14:07 vellames

@vellames-turing a teams customer and myself have experienced the bug. The initial loading of options works, but searching seems to be broken.

ctrlaltdylan avatar Jul 22 '22 15:07 ctrlaltdylan

@vellames-turing a teams customer and myself have experienced the bug. The initial loading of options works, but searching seems to be broken.

ctrlaltdylan avatar Jul 22 '22 15:07 ctrlaltdylan

Oh, got it! I was able to reproduce it now, tks!

vellames avatar Jul 22 '22 15:07 vellames

@vellames-turing great! Thanks for taking a deeper look.

Another customer may have found a similar bug on the instant commit source as well:

https://pipedream.com/community/t/github-organization-repos-not-showing-up/2889/2

Maybe it's the same bug?

ctrlaltdylan avatar Jul 27 '22 13:07 ctrlaltdylan

Hello there @vellames-turing, as this is pending in Doing for a while, do you have bandwidth to work on this now? Also, could you take a look at the issue Pierce mentioned?

vunguyenhung avatar Aug 03 '22 14:08 vunguyenhung

Hey, yeah, I will jump on it today

vellames avatar Aug 03 '22 14:08 vellames

Need some clarification to move ahead. I am not able find the code related to this source. I just pinged @dylburger asking some help :)

vellames avatar Aug 03 '22 17:08 vellames

I'll bring this up with the team during our triage process and we'll investigate. Feel free to move on to the next task @vellames-turing .

dylburger avatar Aug 03 '22 18:08 dylburger

Closing this issue as I'm not able to replicate, looks like this one was fixed!

malexanderlim avatar Oct 27 '23 21:10 malexanderlim