magento-lts icon indicating copy to clipboard operation
magento-lts copied to clipboard

20.0 paypal paylater messages

Open ProxiBlue opened this issue 4 years ago • 5 comments

Description (*)

PayPal US has a new feature called Pay Later (or Pay in 4) This ads in the required messages to inform user that can Pay in 4 instalments, if they want to do so.

ref: https://www.paypal.com/us/for-you/pay-in-4

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts #1435

Manual testing scenarios (*)

  1. In admin setup Paypal Express, must use a US based account (vital)
  2. Set Paypal express buttons for Product and Cart to be enabled
  3. In admin set Merchant location to US, enable Pay Later messages, set PayPal SDK client id (ref: https://developer.paypal.com/docs/business/pay-later/integrate/)

image

  1. In frontend, browse to any product. You will see a message generated that shows the price of the product viewed split PRICE / 4

image

  1. Add item to cart (and more items to cart if you so wish)
  2. In cart you will get same messaging, based on cart grand total / 4

image

  1. Proceed to checkout. You will get same messaging on payment selection

image

  1. In paypal wallet, user wil get ability to do the Pay 4 method. It will ONLY work for USA based paypal accounts/merchants

Questions or comments

First attempt to implement this. Looking for a peer review / suggestions on doing something in code better. Not sure how to enact unit testing for this.

Contribution checklist (*)

  • [ ] Pull request has a meaningful description of its purpose
  • [ ] All commits are accompanied by meaningful commit messages
  • [ ] All automated tests passed successfully (all builds are green)

ProxiBlue avatar Jan 30 '21 08:01 ProxiBlue

Just noticed this contains unwanted file mode changes on media files

image

I am removing

Might be a need for an automated test, any edits/changes in media folder ?

ProxiBlue avatar Feb 02 '21 00:02 ProxiBlue

Just noting PayPal Australia have announced; In an announcement on Wednesday, the Nasdaq-listed giant said its BNPL solution will be available to its 9 million Australian customers in early June (2021), ready for use by the end of financial year sales.

pauldpauld avatar Mar 14 '21 23:03 pauldpauld

@pauldpauld

Yep, they have a tough market to break into, with 3 established services already in operation, and doing well. That said, I will adjust this PR to allow Australia in country selections, as it was locked to USA only for config availability

ProxiBlue avatar Mar 15 '21 00:03 ProxiBlue

FWIW, PayPal has offered my existing clients lowered rates to display this messages, in a fairly aggressive push to market in US. WIll be interesting to see what incentives they will offer AU side.

ProxiBlue avatar Mar 15 '21 00:03 ProxiBlue

Adjusted to allow Australia, and general improvement on actual way it was implemented on cart and product pages

ProxiBlue avatar Mar 15 '21 05:03 ProxiBlue

Hi, paypal pay later is now available in italy and other countries. When you merge this patch?

matteotestoni avatar Nov 09 '22 11:11 matteotestoni

@matteotestoni did you test this PR? if so can you add an "approved" review? thanks!

fballiano avatar Nov 09 '22 15:11 fballiano

From what I can see in the source code this PR is only valid for the USA and Australia. If it is also valid for other countries, changes must be made, in the Backend only US, AU are listed as countries codes.

addison74 avatar Nov 09 '22 16:11 addison74

image

matteotestoni avatar Nov 09 '22 16:11 matteotestoni

maybe a multiselect where user choose countries where to activate pay later. Would be a good new feature

matteotestoni avatar Nov 09 '22 16:11 matteotestoni

Hello, FYI, I don;t currently have any capacity to fix any issues, update any code to effect this 2 year old MR Feel free to fork, and update accordingly.

Maybe sometime in december.

ProxiBlue avatar Nov 09 '22 22:11 ProxiBlue

I have written a 3rd party extension if you are interested: https://github.com/empiricompany/openmage-paypal-pay-later-banner-info

empiricompany avatar Feb 06 '23 09:02 empiricompany

Since this PR is now outdated because of https://github.com/OpenMage/magento-lts/pull/1437#discussion_r1157078079 I think we should add @empiricompany's module to our recommended modules (it has many more features) and close this PR.

fballiano avatar Apr 04 '23 10:04 fballiano

Since this PR is now outdated because of #1437 (comment) I think we should add @empiricompany's module to our recommended modules (it has many more features) and close this PR.

Yes, I also think so, especially since I wanted to suggest different integration methods in the frontend by using other layout handlers without alter any phtml. We can decide to leave it as a separate module, and if I find the time, I can create another PR to integrate it in the same way.

empiricompany avatar Apr 04 '23 11:04 empiricompany

@empiricompany I've added your module on our "readthedocs" and on https://github.com/fballiano/awesome-openmage

fballiano avatar Apr 04 '23 17:04 fballiano

I am closing this PR. There is already a solution to the reported issue here https://github.com/OpenMage/magento-lts/pull/1437#issuecomment-1418755307. Also, the author is not able to fix any requests or code issues.

addison74 avatar Jul 14 '23 14:07 addison74