PySnip icon indicating copy to clipboard operation
PySnip copied to clipboard

Infogulch elaboration

Open noway opened this issue 10 years ago • 6 comments

There are a lot of changes, but i'm confident that they are safe for pysnip. Most of them are edits for userscripts.

Most nasty stuff going on in commands.py and in cython/native files (vxl.pxd, vxl.pyx, vxl_c.cpp, vxl_c.h, world_c.cpp).

Changes in pyspades editor are also huge, but for me they are fine (I used this version of pyspades editor, nothing unordinary)

Merge conflicts were in pyspades/master.py (different whatismyipapi site), .gitignore, config.txt, contrib/ directory.

Otherwise everything looks perfectly fine.

noway avatar Apr 12 '15 04:04 noway

This is quite a lot of loose stuff for a single PR I think, some of which is completely unnecessary, such as the IP. Might possibly be some redundant commits as well. I'll have to dig through this is a bit more.

NateShoffner avatar Apr 13 '15 01:04 NateShoffner

Ok, I left IP_GETTER site unchanged.

noway avatar Apr 13 '15 04:04 noway

@noway421 I've been working on a fork of this project with the aim of tidying it up and experimenting (with things like porting to python3, depending on vanilla upstream pyenet) at swalladge/PySnip. I'm open to any radicale changes and improvements, so feel free to submit pull requests to it or contact me if you are still working on the project. :)

samuelallan72 avatar Mar 17 '16 08:03 samuelallan72

nice, good luck with that

10se1ucgo avatar Mar 31 '16 02:03 10se1ucgo

@swalladge I like the config refactoring. If you'd like, feel free to submit a PR here for it.

I'm going to sift through all of these changes here and merge where possible.

NateShoffner avatar Apr 01 '16 10:04 NateShoffner

@NateShoffner sure, will do. :+1:

samuelallan72 avatar Apr 01 '16 23:04 samuelallan72