dashy

dashy copied to clipboard

Environment

Self-Hosted (Docker)

Version

2.1.0

Describe the problem

Updating the config with the "old" editor tree/code doesn't save changes to the config file on disk, just writes the config again with same data. Using the interactive editor it saves it fine. Looking at the POST request send when trying to save, in case of the interactive editor the value passed includes the config with the changes. But when looking at the same POST with the other editor it just passes on the same config as before it was edited.

Tested on my config and also a fresh container. Tried clearing cookies and rebuild, but I'm guessing that doesn't matter much if data doesn't reach the config anyway. Also saving to local doesn't work either in the "old" editor. If you preview the changes it writes changes instantly, I'm guessing it uses the same layout and functions as the interactive editor. Most likely related to #603, opened this as that had no real info.

Additional info

Interactive edit writes new data to config

"Old" editor writes same/old data to config

Edit using "Old" editor, text in the notepad is the config value found in the save POST request

Config value passed to the POST request when edited with interactive editor

Please tick the boxes

• [X] You are using a supported version of Dashy (check the first two digits of the version number)
• [X] You've checked that this issue hasn't already been raised
• [X] You've checked the docs and troubleshooting guide
• [X] You agree to the code of conduct

I am also having this same issue.

I am working on a complete re-work of how config is managed to make things faster, and that should also fix this issue.

I think duplicate of #603, but this ticket is much clearer with lots of really good info, so keeping open.

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

See https://github.com/Lissy93/dashy/discussions/799

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

See #799

This issue has gone 6 weeks without an update. To keep the ticket open, please indicate that it is still relevant in a comment below. Otherwise it will be closed in 5 working days.

I'll go ahead and close this one you already got it planned in #799, to prevent having to reply it to every 6 weeks and save you having to close it in the future anyway. Thanks for the hard work :)