findbugs-slf4j

findbugs-slf4j copied to clipboard

for #70

@KengoTODA this fails locally for me with this message, which makes no sense to me, can you help:

-------------------------------------------------------------------------------
Test set: jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest
-------------------------------------------------------------------------------
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.079 sec <<< FAILURE! - in jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest
testExceptionMethods()  Time elapsed: 0.076 sec  <<< ERROR!
java.lang.ExceptionInInitializerError
	at jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest.testExceptionMethods(UsingGetStackTraceTest.java:18)
Caused by: java.lang.IllegalStateException: Unable to load core plugin
	at jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest.testExceptionMethods(UsingGetStackTraceTest.java:18)
Caused by: edu.umd.cs.findbugs.PluginDoesntContainMetadataException: Core pluginfindbugs-2.0.2.jar doesn't contain findbugs.xml; got jar:file:/home/vorburger/dev/github/KengoTODA/findbugs-slf4j/bug-pattern/target/bug-pattern-1.4.1-SNAPSHOT.jar!/findbugs.xml from sun.misc.Launcher$AppClassLoader[file:/home/vorburger/dev/github/KengoTODA/findbugs-slf4j/test-case/target/surefire/surefirebooter1722547952841405469.jar]
	at jp.skypencil.findbugs.slf4j.UsingGetStackTraceTest.testExceptionMethods(UsingGetStackTraceTest.java:18)

That bug-pattern-1.4.1-SNAPSHOT.jar DOES contain findbugs.xml, so not sure what it's trying to tell me... :smiley:

@KengoTODA I've written the test differently in the 3rd commit (like the existing ones), so now it passes.

Update CHANGELOG.md and README.md.

done.

I will read implementation changes carefully, later.

thanks!

At least I don't like naming like AbstractDetectorForParameterArray2.

how would you name it?

@KengoTODA how is this coming along - any chance we can wrap this up soon-ish?

@KengoTODA I've taken all your previous code review feedback (thank you) into account. OK for you now?

@KengoTODA would you be willing to finally merge this if I resolved the conflicts? (Those appeared after.)

@KengoTODA I've rebased and resolved conflicts and squased this now - how about finally merging?

@vorburger could you rebase your branch? I've updated master to skip SonarQube analysis for external PR.

@vorburger could you rebase your branch?

done

@KengoTODA I had taken all your previous code review feedback into account. How about merging?

@KengoTODA ?

@KengoTODA are you willing to merge this if I resolve conflicts now? I am asking because I have done that twice in the past, and can't keep spending time to rebase a PR I'm unclear about whether you even consider merging it, and have thus ignored this.

Thought about this again when I found a catch & printStackTrace ... see https://issues.apache.org/jira/browse/FINERACT-696 ... @KengoTODA will you merge this if I resolve conflicts now? I am asking because I have done that twice in the past, and can't keep spending time to rebase a PR I'm unclear about whether you even consider merging it...

Hello @KengoTODA I'm doing a year end clean up of my personal https://github.com/pulls and wanted to ask if you would still consider merging this very old Pull Request if I rebased it, or if we should forget about and close this? (This is a bulk message I'm posting to many issues to gauge what is still revelant.)