advanced-security-compliance

advanced-security-compliance copied to clipboard

Describe the bug Code scanning fails for new branch when there's an alert for master branch. The fix for the alert is in the new branch.

To Reproduce Steps to reproduce the behavior:

1. Hard code a password in master and run the action against it. It will generate a code scanning alert
2. Open a pull request with a fix for the hard coded password
3. Action will fail in the new pull request even if there's a fix for the issue in there

Expected behavior Action should succeed in the new pull request as there's a fix for the code scanning alert

Screenshots Error in master:

Just master is an option here:

Action still fails in fix pull request :

Change that fixes the issue:

@oliveiraleom Thanks for reporting this, I'll take a look at this shortly and get back to you with a patch.

@oliveiraleom This issue is being closed and more to the new repo under another issue https://github.com/advanced-security/policy-as-code/issues/2