Garry Fang comments

Results 109 comments of


                                            Garry Fang

Incompatible changes about custom resource metrics

Hi @CatherineF-dev. I introduce #1644 and want to extend KSM by using it as a dependency library. So we could build our own repo like this. Here is my case,...

Incompatible changes about custom resource metrics

> QQ: got it. Why do you want to use KSM as library instead of deploying the KSM agent? > > Is it because you only want customresource feature and...

Add placement for bindingSpec

This PR could help #2968 for determining whether a binding is divided scheduling easily.

Discussion about adding propagate priority during scheduling

OK.

add implicit priority for OP and COP

Generally LGTM, except this nit. https://github.com/karmada-io/karmada/pull/2609#discussion_r1028045448

add implicit priority for OP and COP

/lgtm

Is it possible for kubelet to pass pod name and namespace to device plugin?

Hi @ffromani, I agree with you. I'm worried about increasing coupling of device plugin and kubelet as well. So for me, I try to let this information deliverd as transparent...

KEP: Split Detector and Add PropagationPolicy Controller

/assign

KEP: Split Detector and Add PropagationPolicy Controller

Wow, this proposal is really good to me. Actually this proposal helps us to clean up the dector. Now the dector contributes to building RB and aggregating RB status, it...