system-tests

system-tests copied to clipboard

Motivation

This PR adds more DBM tests for Python and NodeJS integrations (NodeJS tests are currently failing, as the relevant PR has not been merged yet: PR).

This PR also updates the mysql and postgres databases to have more identifiable database names (using system_tests as a database name is not very helpful when other services and variables are also system_tests).

Changes

adds dbm tests asserting that a dbm comment is added to sql query

Workflow

1. ⚠️ Create your PR as draft ⚠️
2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
3. Mark it as ready for review
   • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
   • Framework is modified, or non obvious usage of it -> get a review from R&P team

:rocket: Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

• [ ] Relevant label (run-parametric-scenario, run-profiling-scenario...) are presents
• [ ] If PR title starts with [<language>], double-check that only <language> is impacted by the change
• [ ] No system-tests internal is modified. Otherwise, I have the approval from R&P team
• [ ] CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
• [ ] A docker base image is modified?
  • [ ] the relevant build-XXX-image label is present
• [ ] A scenario is added (or removed)?
  • [ ] Get a review from R&P team

NodeJS tests are currently failing, as the relevant PR has not been merged yet

I can make a informal review, but the PR needs to be ready to merge for the real review

This PR also updates the mysql and postgres databases to have more identifiable database names (using system_tests as a database name is not very helpful when other services and variables are also system_tests).

Thanks a lot :)

Do you have any idea about the Python test failures? They must be related somehow but I'm not exactly sure. If not, who may own them?

Do you have any idea about the Python test failures? They must be related somehow but I'm not exactly sure. If not, who may own them?

Found the issue, fixing it.

The PR that fixes python issue : #2402

You can rebase your branch to fix python issue

@cbeauchesne any idea on the 4 failing python suites? I'm unsure how any of my changes could cause the uwsgi-poc and uds-flask suites to have build / run failures but not the main flask-poc weblog.

@wconti27 no idea. Does it happen locally ?