Maui icon indicating copy to clipboard operation
Maui copied to clipboard

Duplicate output filenames: fullscreen when using MediaElement

Open jfversluis opened this issue 1 year ago • 7 comments

It seems that with the latest nightly (and maybe even stable now?) there are sometimes issues with a duplicate file name for the fullscreen icon file that is used in MediaElement.

We need to investigate how this happens and how to get rid of it!


[...] I am getting this error: Error: One or more duplicate file names were detected. All image output filenames must be unique: fullscreen (/{path}/.nuget/packages/communitytoolkit.maui.mediaelement/99.0.0-build-1813.105074/buildTransitive/Images/fullscreen.svg), fullscreen (/{path}/.nuget/packages/communitytoolkit.maui.mediaelement/99.0.0-build-1813.105074/buildTransitive/Images/fullscreen.svg)

Any ideas?

Originally posted by @briankanelson in https://github.com/CommunityToolkit/Maui/issues/1110#issuecomment-2074953533

jfversluis avatar May 06 '24 08:05 jfversluis

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.

BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

ne0rrmatrix avatar May 06 '24 11:05 ne0rrmatrix

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result.

BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks. https://github.com/CommunityToolkit/Maui/issues/1110#issuecomment-2094217710

luisabreu84 avatar May 06 '24 14:05 luisabreu84

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result. BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks. #1110 (comment)

I cannot replicate the issue without a sample. I have tried both the sample app from repo and I created my own. I have had zero success at creating the bug. Please provide or attach a sample that clearly demonstrates the issue.

ne0rrmatrix avatar May 06 '24 14:05 ne0rrmatrix

Can you provide more info? I created a sample project and tried both media element from latest source (99.0.0-preview1839) and from current release 3.1.1. I had zero issues. Is there a specific setting I need to set in csproj file? I am trying with <MauiVersion>8.0.21</MauiVersion> I tried <MauiVersion>8.0.14</MauiVersion> with the same result. BTW #1813 was merged last week and is/was a PR that fixes ios crash issues and if you want to test the pr where the file was added you can test #1692 which added full screen support. Testing again earlier versions might be useful as you should get zero reference to file at all. It did not exist then.

@ne0rrmatrix could you please take a look to this comment, i described how you can reproduce it. Thanks. #1110 (comment)

I cannot replicate the issue without a sample. I have tried both the sample app from repo and I created my own. I have had zero success at creating the bug. Please provide or attach a sample that clearly demonstrates the issue.

See attahcments.

Open Solution -> Run for iOS Debug - Any CPU | iPhone Simulator

Output 1>Microsoft.Maui.Resizetizer.After.targets(623,9): Error : One or more duplicate file names were detected. All image output filenames must be unique: fullscreen (/Users/.../.nuget/packages/communitytoolkit.maui.mediaelement/3.1.1/buildTransitive/Images/fullscreen.svg)

Screenshot 2024-05-06 at 9 26 28 AM

CommunityToolkitPckgTest.zip

luisabreu84 avatar May 06 '24 14:05 luisabreu84

I looked at the provided sample. Can verify that when you add a class library to an existing project where both have media element in both projects you will get an error about duplicate file names. I will investigate the issue.

ne0rrmatrix avatar May 06 '24 14:05 ne0rrmatrix

possibly related issue found here: https://github.com/dotnet/maui/issues/19840 Will investigate further and see if they are related.

ne0rrmatrix avatar May 06 '24 15:05 ne0rrmatrix

Hi @ne0rrmatrix! any possible date to release this change? Thanks!

luisabreu84 avatar May 16 '24 12:05 luisabreu84

hello! any news here? Thanks!

luisabreu84 avatar May 24 '24 14:05 luisabreu84

@luisabreu84 I am waiting on review and it looks good to go. Just need approval and then a maintainer with write privileges needs to push the changes.

ne0rrmatrix avatar May 24 '24 15:05 ne0rrmatrix

I've approved with one minor comment 👍

bijington avatar May 24 '24 17:05 bijington