capacitor-updater icon indicating copy to clipboard operation
capacitor-updater copied to clipboard

bug: Fix sonarcloud issues

Open riderx opened this issue 2 years ago โ€ข 22 comments

Sonarcloud has a report of 59 issues. The goal is to reduce that to 0 by or changing the code or explaining why it's safe.

riderx avatar Feb 18 '23 03:02 riderx

/bounty 100

riderx avatar Feb 18 '23 03:02 riderx

๐Ÿ’Ž $100 bounty โ€ข Capgo

Steps to solve:

  1. Start working: Comment /attempt #163 with your implementation plan
  2. Submit work: Create a pull request including /claim #163 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Additional notes:

โ„น๏ธ If something is not clear ask before working on it, otherwise your chance to rework it is high ๐ŸŽฅ To claim you need to provide in your PR a demo video of the change ๐Ÿ‘จโ€๐Ÿ‘ฉโ€๐Ÿ‘งโ€๐Ÿ‘ฆ Join the Discord to get help ๐Ÿ“ Check all Bounty rules

Thank you for contributing to Cap-go/capacitor-updater!

Add a bounty โ€ข Share on socials

Attempt Started (GMT+0) Solution
๐ŸŸข @pranjalg13 Aug 12, 2023, 6:08:39 PM WIP
๐ŸŸข @pbkompasz Aug 14, 2023, 3:28:18 PM WIP
๐Ÿ”ด @rishi-raj-jain Aug 18, 2023, 8:49:04 PM WIP
๐Ÿ”ด @archie9211 Oct 10, 2023, 6:24:21 PM WIP
๐ŸŸข @ologbonowiwi Oct 16, 2023, 8:00:44 PM #289

algora-pbc[bot] avatar Feb 18 '23 03:02 algora-pbc[bot]

Hey @riderx Do you mind sharing where we can see the list of issues?

ujwalkumar1995 avatar Feb 18 '23 12:02 ujwalkumar1995

sorry i thinked it was present in my message. here you go: https://sonarcloud.io/project/overview?id=Cap-go_capacitor-updater

riderx avatar Feb 19 '23 11:02 riderx

@riderx Thank you. I will start working on this. Might not be able to complete all of the issues. Will try to resolve to the best of my capability.

ujwalkumar1995 avatar Feb 19 '23 12:02 ujwalkumar1995

@riderx , is this still open?

harishkadamudi avatar Aug 12 '23 02:08 harishkadamudi

Yes

riderx avatar Aug 12 '23 17:08 riderx

@riderx can i work on this had raised a request earlier for the same, but somehow got deleted Thanks

pranjalg13 avatar Aug 12 '23 17:08 pranjalg13

I want to know what are the required changes since it mentions there are 60 issues on sonarcloud

pranjalg13 avatar Aug 12 '23 18:08 pranjalg13

/attempt #163

Options

pbkompasz avatar Aug 14 '23 15:08 pbkompasz

Note: The user @pranjalg13 is already attempting to complete issue #163 and claim the bounty. If you attempt to complete the same issue, there is a chance that @pranjalg13 will complete the issue first, and be awarded the bounty. We recommend discussing with @pranjalg13 and potentially collaborating on the same solution versus creating an alternate solution.

algora-pbc[bot] avatar Aug 14 '23 15:08 algora-pbc[bot]

Please guys be mindful that only one person would be paid, so don't work for free. The goal is to fix as much as you can and if some don't make sense explain why. The code has to build after your change and still work as expected

riderx avatar Aug 14 '23 15:08 riderx

Sorry, I only looked for a /attempt comment. I did not see that there was an attempt already. Is there any documentation on how to build the ios plugin?

pbkompasz avatar Aug 14 '23 17:08 pbkompasz

or with npm command verify or with android studio and xcode, like any native project

riderx avatar Aug 15 '23 00:08 riderx

Hey @pbkompasz you can try this if you want, leaving the issue to you Thanks

pranjalg13 avatar Aug 15 '23 03:08 pranjalg13

I see no one working on this actively, /attempt #163

Options

rishi-raj-jain avatar Aug 18 '23 20:08 rishi-raj-jain

/attempt #163

Options

archie9211 avatar Oct 10 '23 18:10 archie9211

@riderx Just wanted to know if this issue is still open to work and claim bounty. Thank you

archie9211 avatar Oct 10 '23 18:10 archie9211

๐Ÿ’ก @ologbonowiwi submitted a pull request that claims the bounty. You can visit your org dashboard to reward.

algora-pbc[bot] avatar Oct 16 '23 20:10 algora-pbc[bot]

Hey folks! Since we're not having any activity here, I'm attempting this

/attempt #163

Options

wesleymatosdev avatar Oct 16 '23 20:10 wesleymatosdev

Can you review #289 @riderx?

The variable name rule is the only rule that makes more sense to disable.

CONSTANT_NAME is a convention to most languages we use; ignoring the Swift community convention rather than the cap-go convention here makes more sense.

If you find anything that needs to be changed on my PR, let me know :smile:

wesleymatosdev avatar Oct 16 '23 20:10 wesleymatosdev

@riderx Is this bounty still open ? I see 64 code smells.

KumarNayan avatar Dec 23 '23 06:12 KumarNayan