aelf-web3.js icon indicating copy to clipboard operation
aelf-web3.js copied to clipboard

typescript declaration

Open AbigailDeng opened this issue 2 years ago • 4 comments

AbigailDeng avatar Mar 20 '23 09:03 AbigailDeng

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
18.63% potter-sun 13 19
7.84% lhoopox 5 8
3.92% Alef-hz 7 4
0.98% 轩辕焮痕 1 1

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
examples/browser/requestByFetch.html50.00%1 out of 2 times
examples/browser/index.html50.00%1 out of 2 times
test/.DS_Store50.00%1 out of 2 times
.github/workflows/standard-version.yml50.00%1 out of 2 times
test/e2e/keyStore.test.js50.00%1 out of 2 times

Committed file ranks

  • 0.00%[src/util/formatters.js]
  • 71.01%[test/unit/util/formatter.test.js]
  • 97.10%[README.md]
  • 93.12%[src/util/proto.js]
  • 86.96%[test/unit/util/proto.test.js]
  • 96.74%[src/contract/index.js]
  • 57.61%[proto/virtual_transaction.proto.json]
  • 57.61%[proto/transaction_fee.proto.json]
  • 57.61%[proto/virtual_transaction.proto]
  • 57.61%[proto/core.proto]
  • vizipi[bot] avatar Mar 20 '23 09:03 vizipi[bot]

    Jest Coverage

    File % Stmts % Branch % Funcs % Lines Uncovered Line #s
    All files 99.44 98.85 99.02 99.41
    File % Stmts % Branch % Funcs % Lines Uncovered Line #s
    All files 99.44 98.85 99.02 99.41
    _src 100 100 100 100
    _ index.js 100 100 100 100
    _src/chain 100 100 100 100
    _ chainMethod.js 100 100 100 100
    _ index.js 100 100 100 100
    _src/contract 99.37 97.91 100 99.36
    _ contractMethod.js 99.15 97.22 100 99.15 104
    _ index.js 100 100 100 100
    _src/util 99.29 98.75 98.46 99.25
    _ bloom.js 100 100 100 100
    _ errors.js 100 100 100 100
    _ formatters.js 100 100 100 100
    _ httpProvider.js 96.42 93.54 92 96.33 30,218,224,228
    _ keccak.js 100 100 100 100
    _ keyStore.js 100 100 100 100
    _ merkleTree.js 100 100 100 100
    _ proto.js 100 100 100 100
    _ requestManage.js 100 100 100 100
    _ settings.js 100 100 100 100
    _ transform.js 100 100 100 100
    _ utils.js 100 100 100 100
    _src/wallet 100 100 100 100
    _ index.js 100 100 100 100
    Done in 49.61s.

    github-actions[bot] avatar Apr 14 '23 03:04 github-actions[bot]

    interface IChain{

    ChainStatus GetStatus()

    hzz780 @.***>于2023年10月26日 周四17:01写道:

    @.**** commented on this pull request.

    In types/chain/index.d.ts https://github.com/AElfProject/aelf-web3.js/pull/112#discussion_r1372828998 :

    • Message: string;
    • Details: string | null;
    • Data: {
    •  [key in string]: string;
      
    • };
    • ValidationErrors:
    •  | [
      
    •      {
      
    •        Message: string;
      
    •        Members: string[];
      
    •      }
      
    •    ]
      
    •  | null;
      
    • }; +} +export interface IGetChainStatus {

    All the next IGetXxxxs are IXxxx?

    — Reply to this email directly, view it on GitHub https://github.com/AElfProject/aelf-web3.js/pull/112#pullrequestreview-1699082043, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMFED33D6S6WJ2YBT4S2T3YBIRH5AVCNFSM6AAAAAAWA26GA6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOJZGA4DEMBUGM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

    loning avatar Oct 26 '23 09:10 loning

    🔴 Total coverage is lower than the default branch

    Lines Branches Functions Statements
    98.93% (-0.48%) 97.54% (-1.31%) 99.07% (+0.05%) 98.98% (-0.46%)

    Detailed report

    click to open the diff coverage report
    File Lines Branches Functions Statements
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/chainMethod.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/chain/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/contractMethod.js 99.31% (+99.31%) 95.45% (+95.45%) 100.00% (+100.00%) 99.33% (+99.33%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/contract/index.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/bloom.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/errors.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/formatters.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/httpProvider.js 92.37% (+92.37%) 89.85% (+89.85%) 92.00% (+92.00%) 92.50% (+92.50%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keccak.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/keyStore.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/merkleTree.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/proto.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/requestManage.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/settings.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/sha256.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/transform.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/util/utils.js 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%) 100.00% (+100.00%)
    /home/runner/work/aelf-web3.js/aelf-web3.js/src/wallet/index.js 100.00% (+100.00%) 90.90% (+90.90%) 100.00% (+100.00%) 100.00% (+100.00%)

    github-actions[bot] avatar Aug 22 '24 08:08 github-actions[bot]