action-wordpress-plugin-deploy

action-wordpress-plugin-deploy copied to clipboard

• I think the commands will output serious errors with --quiet and not just suppress everything. SVN says it displays nothing or just a summary so it's probably a good fit here. I prefer it in general for all commands that have it from what I learned.
• Redirecting to /dev/null means the output is still written and then discarded, that's less efficient than not writing it (and not allocate, prepare that output to be written)

Source for 2nd point and more info on this

This seems fine to me - I'd love to know what SVN could potentially show for the add and rm commands just for due diligence, it's possible it would actually show more useful info if it's a reasonable summary.

@nextgenthemes are you able to help resolve the merge conflicts that Faisal noted above?

Not really, I am not really up for spending any time on this. It was just a TINY suggestion that does not really mater that much. I am running my own action based on this written on php if anyone is interested. https://github.com/nextgenthemes/advanced-responsive-video-embedder/blob/master/actions/wp-plugin-deploy/wp-plugin-deploy.php

It works locally and on Github with the same script. It also supports what I called "workingdir" that enabled it to operate out of a different folder that was mission in this.

Feel free to edit this --quiet in yourself for this.

@nextgenthemes thanks for the quick response, understood and I appreciate the contribution either way!

@10up/open-source-practice if anyone is interested in picking this up, then please go for it, otherwise if this sits without updates I'll likely close at some point 🙏🏼