Tobias Meggendorfer

Results 74 comments of Tobias Meggendorfer
trafficstars

Ugh. What a headache. What if instead of providing a new method we check whether the given remapping function (in `COMPUTE_IF_PRESENT`) is `instanceof JDK_PRIMITIVE_BI_FUNCTION`? Unfortunately, these methods aren't bulk operations,...

Well, source compatibility is important. I'd rather have different names than adding that cast (pragmatically, that's less characters). Just compare: `map.mergeIntInt(1, 2, Integer::sum)` to `map.mergeInt(1, 2, (IntBinaryOperator) Integer::sum)`. I personally...

> A good question: why not creating type-specific BiFunctions? From what I understand in that case here the advantage is only in the return type... Well, if you want all...

I think a more canonical approach would be to move to the `src/main/java` / `src/test/java` and `src/main/generated` etc. structure. This then also would be understood by IDEs I think

IIRC, canonical is `src/main` and `src/test` for different source / compilation sets (`main` is everything that is part of the distribution, `test` is part of testing, you could have `src/test-fixtures`...

What about ```java @Mapping(source = "getBillingCurrencyCode", target = "currencyCode") public abstract Amount map(CurrencyAmountType amount); ``` or simply declare ```java public String map(CurrencyAmountType amount) { return amount.getBillingCurrencyCode(); } ``` mapstruct is...

Ah, sorry, I misunderstood you :) Can you try to create a minimal example? I guess that the `Fare` mapping as well as all `@Xml...` annotations could be pruned. One...

I like both ideas! Adding `@Mapping` to the parameters feels very natural - everything makes sense here! (except the `source` of `@Mapping` but that's a small price to pay IMO)...

Addition: Reading throught the docs again: > Also, you can optionally use extendedKeyUsage attributes on intermediate CA certificates to limit which ones are allowed to issue code signing certificates. So...

More info: With `system.conf` having `check-purpose=any`, it works. Running with `G_MESSAGES_DEBUG="all"` reveals the following (maybe it is helpful): intermediate: ``` object: X509v3 Basic Constraints (2.5.29.19) critical: TRUE value: 0000 -...