ts-protoc-gen icon indicating copy to clipboard operation
ts-protoc-gen copied to clipboard

WIP: Add generate parameter - Fixes #211

Open Multiply opened this issue 6 years ago • 3 comments

Changes

I've added a relatively crude parameter parse, that allows comma separated arguments, with multiple values delimited by +, as comma is used to distinguish between multiple parameters.

Verification

I've tested it by using a modified version of the bazel rules, following the comment here: https://github.com/Dig-Doug/rules_typescript_proto/issues/10#issuecomment-550334084 I couldn't seem to find any cli tests, so please guide me in the right direction, if I missed them.

Multiply avatar Nov 06 '19 21:11 Multiply

Thank you for raising this.

WRT code structure, can I suggest that you introduce a 'proper' type for the Parameters object instead of relying on {[key: string]: string[]} - this should make things a little more extensible/maintainable in future. I'd also suggest introducing a parseParameters() func to further improve readability.

Please could you also update the documentation? I would suggest that we replace the current references to service= with generate= and standardize on this new parameter.

jonny-improbable avatar Nov 07 '19 18:11 jonny-improbable

How it's going? :)

emil14 avatar May 20 '21 15:05 emil14

We ended up not using this at all, after moving 100% to golang.

If anyone wants to pick it up, feel free to use my work here.

Multiply avatar May 21 '21 05:05 Multiply