immutables-vavr icon indicating copy to clipboard operation
immutables-vavr copied to clipboard

Make VavrMapEncoding consistent with immutables naming

Open dudkiewicz-codes opened this issue 5 years ago • 1 comments

VavrMapEncoding adds Entry prefix for tuple related operations. Current solution has some drawbacks:

  • it isn't configurable
  • it isn't consistent with immutables encoding ( it generates putBar(Map.Entry<? extends K, ? extends V>) method )
  • matter of taste, but in my opinion "Entry" doesn't add any value and makes builder too verbose

How about replacing:

@Encoding.Naming(value = "putEntry*", depluralize = true) with @Encoding.Naming(standard = Encoding.StandardNaming.PUT)

@Encoding.Naming(value = "setEntries*") with @Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL) ?

Also, I would consider replacing @Encoding.Naming(value = "setJavaMap*") with @Encoding.Naming(standard = Encoding.StandardNaming.PUT_ALL)

dudkiewicz-codes avatar Jan 14 '20 13:01 dudkiewicz-codes

I'm open to patches for this, if you have them! I've had very little time to work on this project lately. :sweat:

io7m avatar Jan 14 '20 13:01 io7m