immich icon indicating copy to clipboard operation
immich copied to clipboard

Update asset.ts - fix file path translation from Windows > Linux

Open Donovoi opened this issue 1 year ago • 6 comments

Some of my folders in Windows had special characters like "@" which were not being handled correctly and stopped everything else from being processed. This uses the library "upath" to fix the issue. I'm not a typescript developer so please let me know if I'm doing something incorrect.

Thank you

Donovoi avatar May 04 '24 03:05 Donovoi

Can you update your PR? The build fails and you have some strange changes in the imports etc (changed " to ') etc. Please fix the build errors :)

JW-CH avatar May 06 '24 08:05 JW-CH

HI I believe I sorted the issues, but how do I test if the build is ok? I've tried to follow https://immich.app/docs/developer/pr-checklist I also ran make e2e and it seems to run

Donovoi avatar May 08 '24 03:05 Donovoi

@Donovoi As a first time contributor, we will have to manually trigger the check run

alextran1502 avatar May 08 '24 03:05 alextran1502

Sweet thank you! Let me know when you do and I'll fix up any issues 😁

Donovoi avatar May 08 '24 03:05 Donovoi

You seem to have an extra dependency "install" that is not required, also the builds and tests are failing. Can you fix these two problems please?

zackpollard avatar May 08 '24 03:05 zackpollard

hopefully that's all done!

Donovoi avatar May 12 '24 02:05 Donovoi

I think this has been superseded by #10430?

bo0tzz avatar Jun 25 '24 11:06 bo0tzz