immich
immich copied to clipboard
Update asset.ts - fix file path translation from Windows > Linux
Some of my folders in Windows had special characters like "@" which were not being handled correctly and stopped everything else from being processed. This uses the library "upath" to fix the issue. I'm not a typescript developer so please let me know if I'm doing something incorrect.
Thank you
Can you update your PR? The build fails and you have some strange changes in the imports etc (changed " to ') etc. Please fix the build errors :)
HI I believe I sorted the issues, but how do I test if the build is ok? I've tried to follow https://immich.app/docs/developer/pr-checklist I also ran make e2e and it seems to run
@Donovoi As a first time contributor, we will have to manually trigger the check run
Sweet thank you! Let me know when you do and I'll fix up any issues 😁
You seem to have an extra dependency "install" that is not required, also the builds and tests are failing. Can you fix these two problems please?
hopefully that's all done!
I think this has been superseded by #10430?