immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(server, web): search location

Open martabal opened this issue 1 year ago • 6 comments

Search the location with a text box

Screenshots

https://github.com/immich-app/immich/assets/74269598/9fd04fad-f245-4c10-b89e-4b2059f51109

martabal avatar Feb 15 '24 23:02 martabal

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7ea97f7
Status: ✅  Deploy successful!
Preview URL: https://f08749a1.immich.pages.dev
Branch Preview URL: https://feat-search-location.immich.pages.dev

View logs

Actually, can't we use this for the search box as well? I think this is a sleek way to search for a location. @alextran1502

mertalev avatar Feb 16 '24 03:02 mertalev

@mertalev @martabal Wow, this is very cool. With the current search box, we know what is available; with this, we will need to perform an estimation. Am I understanding correctly?

alextran1502 avatar Feb 16 '24 04:02 alextran1502

The search box here uses geodata_places, but it should be possible to adapt this to the exif table too

mertalev avatar Feb 16 '24 04:02 mertalev

@mertalev @martabal Wow, this is very cool. With the current search box, we know what is available; with this, we will need to perform an estimation. Am I understanding correctly?

Yes, but more like a suggestion

martabal avatar Feb 16 '24 07:02 martabal

@alextran1502 Yes, that probably can be used for your search

martabal avatar Feb 16 '24 08:02 martabal

Amazing works! it looks and works very well, let's address my comment above and resolve the conflict then we can have this merged

alextran1502 avatar Feb 23 '24 05:02 alextran1502

I'm getting

Error: 500 - 500
y@https://photos-dev.server/node_modules/.vite/deps/@oazapfts_runtime.js?v=80e2c728:152:5
l@https://photos-dev.server/node_modules/.vite/deps/@oazapfts_runtime.js?v=80e2c728:139:9

since this PR, is it possible to fix that somehow? I did fresh git clone, remove everything from docker (including caches) and still occurs.

waclaw66 avatar Feb 26 '24 07:02 waclaw66

Does it work without your reverse proxy ?

martabal avatar Feb 26 '24 08:02 martabal

Does it work without your reverse proxy ?

No, it's the same...

Error: 500 - 500
y@http://localhost:2284/node_modules/.vite/deps/@oazapfts_runtime.js?v=bc1795a2:152:5
l@http://localhost:2284/node_modules/.vite/deps/@oazapfts_runtime.js?v=bc1795a2:139:9

waclaw66 avatar Feb 26 '24 08:02 waclaw66

Does it affect the whole webapp or only this modal ?

I'll take a look this evening

martabal avatar Feb 26 '24 08:02 martabal

It affects whole web app. The root cause is probaly here in server...

Debugger listening on ws://0.0.0.0:9230/91b6385c-5e36-4d1f-8ad7-13cd3a97199e
For help, see: https://nodejs.org/en/docs/inspector
[Nest] 20  - 02/26/2024, 7:34:09 AM    WARN [AppService] Unable to open `www/index.html, skipping SSR.
[Nest] 20  - 02/26/2024, 7:34:09 AM     LOG [CommunicationRepository] Initialized websocket server
Migration "GeodataLocationSearch1708059341865" failed, error: permission denied for language c
/usr/src/app/src/driver/postgres/PostgresQueryRunner.ts:331
            throw new QueryFailedError(query, parameters, err)
                  ^
QueryFailedError: permission denied for language c
    at PostgresQueryRunner.query (/usr/src/app/src/driver/postgres/PostgresQueryRunner.ts:331:19)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at GeodataLocationSearch1708059341865.up (/usr/src/app/src/infra/migrations/1708059341865-GeodataLocationSearch.ts:5:5)
    at MigrationExecutor.executePendingMigrations (/usr/src/app/src/migration/MigrationExecutor.ts:336:17)
    at DataSource.runMigrations (/usr/src/app/src/data-source/DataSource.ts:403:13)
    at DatabaseRepository.runMigrations (/usr/src/app/src/infra/repositories/database.repository.ts:191:5)
    at /usr/src/app/src/domain/database/database.service.ts:50:7
    at /usr/src/app/src/infra/repositories/database.repository.ts:200:15

Worth to mention I'm using postgress container from dev docker compose, db has been created by Immich itself and uses superuser rights, so there was no intervention from my side. Everything should be by the book.

waclaw66 avatar Feb 26 '24 08:02 waclaw66

Yes, it's a migration issue. Weird, I had no problems with this migration.

@mertalev Do you have any idea what could cause that ?

martabal avatar Feb 26 '24 08:02 martabal

I've found the cause, it was missing superuser privilige for postgres user, definitely my mistake, I'm sorry for confusion.

waclaw66 avatar Feb 26 '24 10:02 waclaw66