immich
immich copied to clipboard
feat(mobile): optionally autoplay motion photos in the app
Added the option to autoplay motion photos, like how it is done in the app that shall not be named.
I didn't really know in what Settings Category to put this setting, so I just put it under advanced for now.
I'm not sure how i18n is handled, so I just added the translations for the languages I speak.
Lemme know if there's anything to change/fix 😄
I'm not sure if we need a separate setting for auto-playing motion photos alone. An image viewer setting to determine whether to auto-play videos might be a better option which could include motion photos as well. Let's wait for the opinion of others on this as well.
@alextran1502 / @fyfrey What do you think about a setting to enable / disable auto-play of videos in general and not limit it to motion photos alone?
I think we can handle auto play for live photos and videos the same. At some point, we should take into account (provide a setting) to whether the device has WiFi and only play remote videos in that case. Locally available videos can be auto played anytime.
At some point, we should take into account (provide a setting) to whether the device has WiFi and only play remote videos in that case. Locally available videos can be auto played anytime.
I guess we can handle them incrementally then. We can expose a setting to enable / disable auto-play app wide. And then a setting to auto-play remote assets only when the device is in Wifi.
@arnolicious Would you like to update the handling to extend the setting to auto play videos and motion photos in general instead of just motion photos?
I've implemented the setting to work for both regular videos and motion pictures now, let me know if you have any notes
So right now, the only thing that I can't get to work, is manually playing a video when autoplay is disabled. It seems like the state of the video is stuck on "Initializing" but I can't figure out how to make it play :/
However autoplaying videos and motion pictures works, both when swiping to them aswell as opening them directly. And playing motion pictures manually still works as before
So right now, the only thing that I can't get to work, is manually playing a video when autoplay is disabled. It seems like the state of the video is stuck on "Initializing" but I can't figure out how to make it play :/
Let me know if you need assistance in handling this. I can look into it later today or tomorrow
So right now, the only thing that I can't get to work, is manually playing a video when autoplay is disabled. It seems like the state of the video is stuck on "Initializing" but I can't figure out how to make it play :/
Let me know if you need assistance in handling this. I can look into it later today or tomorrow
Thanks for the offer, I do think I'll need some assistance with that indeed 😅
@arnolicious There were a lot of syncing issues between the existing handling and autoPlay due to which the play pause state was updated inconsistently. I've pushed a commit to handle it. Can you please look into it?
Looks perfect to me, thanks!
I will close this PR as there are many conflicts. Apologies and now that we have long press to play motion photos which I think somewhat help with the goal this PR is trying to achieve