immich icon indicating copy to clipboard operation
immich copied to clipboard

feat: Search filtering logic

Open alextran1502 opened this issue 1 year ago • 2 comments

image

alextran1502 avatar Feb 07 '24 18:02 alextran1502

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4cfc5b0
Status:⚡️  Build in progress...

View logs

I was thinking that we always return an object of all search options. This way, we could update the suggestions on select of an option, not when opening a combobox. Should help with performance a lot.

I was debating on this, it means we will do the filtering on the client. I opt-in for filtering on the server instead, to keep the payload light.

alextran1502 avatar Feb 09 '24 16:02 alextran1502

Bugs:

  • X button covers new filter button when some search string is entered... obrazek
  • filter window cannot be closed clicking outside
  • search button doesn't work, it does nothing
  • using Enter to confirm search reloads the whole page on /photos?context=panorama&start-date=&end-date=&radio-type=all without any result - regular photos page
  • using new filter from the results returned by old simple search, reloads the page always with no results with message No results Try a synonym or more general keyword

browser: Firefox, Chrome

waclaw66 avatar Feb 14 '24 08:02 waclaw66