immich [BUG] Partner Sharing - Unable to delete photo

trafficstars

The bug

When partner sharing on the time-line is enabled, the user who doesn't own the picture cannot delete a shared picture. The delete button does nothing. If this is by design, then the button needs to be hidden, or some sort of UI element to tell the user he can't delete partner's photos. Even better would be if there was an option in the settings to allow a user to do such a thing.

The OS that Immich Server is running on

Ubuntu 22.04

Version of Immich Server

V1.88.1

Version of Immich Mobile App

V1.88.1

Platform with the issue

[X] Server
[X] Web
[X] Mobile

Your docker-compose.yml content

Same as example one.

Your .env content

Same as example one

Reproduction steps

1. Enable partner sharing
2. Enable shared photos on timeline
3. Try to delete a photo that belongs to your partner. Mobile and Web
...

Additional information

No response

Nov 21 '23 07:11 yurividal

Looks like the following may be the culprit: https://github.com/immich-app/immich/blob/8a2b36ad55169a6befe4a23bfac8e4f8b697af43/web/src/lib/components/photos-page/actions/delete-assets.svelte#L40

I don't know typescript so I'm having a hard time tracking this backward but at an initial glance, it may work to change this to use getAssets instead...?

Dec 02 '23 14:12 BarrettLowe

This is as designed. Let me think of a way to make it less confused

Dec 02 '23 14:12 alextran1502

This is as designed. Let me think of a way to make it less confused

Thought it would be as design. Indeed a UI hint is needed here.

Even better would be if there was a option to allow deletion of partners photos.

(Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures)

Dec 03 '23 11:12 yurividal

This is as designed. Let me think of a way to make it less confused

Thought it would be as design. Indeed a UI hint is needed here.

Even better would be if there was a option to allow deletion of partners photos.

(Example: my wife is constantly taking pictures of receipts or things she only needs for a few minutes, and never remembers to delete them from immich. I'd love to be able to clean these every now and then, instead of filling our precious storage space with useless pictures)

I'd also love to see this. In my case, I am always the one "thinning out" the photos, deleteing blurred ones, keeping only the best shot of many of the same motive. And I would love to just show my partners photos in my timeline (especially with kids), but having them raw is not really satisfying.

Kind of a big ask, but for me the optimal solution would be something like this: I mark the pictures for deletion and my partner gets a notification/hint to look over them and confirm. This way, she doesn't have the work and can still be sure I delete nothing important to her.