immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(web): new shortcuts

Open martabal opened this issue 2 years ago • 10 comments

This PR implements the following shortcuts when viewing assets individually:

  • f to mark the current viewing asset as favorite
  • Shift + a to archive it
  • Shift + d to download it

and while viewing the asset grid:

  • / to go to the explore page

This is the same behavior as Google Photos even when caps lock is activated.

martabal avatar Jul 04 '23 21:07 martabal

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Jul 10, 2023 0:33am

vercel[bot] avatar Jul 04 '23 21:07 vercel[bot]

Found this bug with this feature, is it normal ?

martabal avatar Jul 05 '23 13:07 martabal

Found this bug with this feature, is it normal ?

No, seems like something is not getting cleaned up, which results in new subscribers/listeners getting added with each subsequent event. It still is there with your latest code?

jrasm91 avatar Jul 05 '23 14:07 jrasm91

Yep still

martabal avatar Jul 05 '23 16:07 martabal

Can we add notifications for each action such as favorite, and archive?

alextran1502 avatar Jul 09 '23 05:07 alextran1502

Can we add notifications for each action such as favorite, and archive?

Sure ! Do you want a notifications only when the shortcut is pressed ?

martabal avatar Jul 09 '23 11:07 martabal

Notifications should always happen I think.

jrasm91 avatar Jul 09 '23 12:07 jrasm91

I added notifications for favorite and download, it's already implemented for archive.

martabal avatar Jul 09 '23 16:07 martabal

Should we add a notification even for navigation actions (such as go to explore tab) ?

martabal avatar Jul 09 '23 23:07 martabal

I don't think so

jrasm91 avatar Jul 09 '23 23:07 jrasm91