immich icon indicating copy to clipboard operation
immich copied to clipboard

refactor(server)!: add/remove album assets

Open jrasm91 opened this issue 2 years ago • 1 comments

Breaking Change: Mobile app and server must both be up to date

If the mobile app and server are out of sync the following will no longer work:

  • Add assets to albums
  • Remove assets from albums

TODO:

  • [x] Unit tests
  • [x] Web testing
  • [ ] Mobile testing
  • [ ] Perf testing
  • [x] Access testing
  • [x] Test removing current thumbnail

Test Scenarios

  • Add own assets to album
  • Remove own assets from album
  • Add own assets to a non-owned, shared album
  • Drag and drop new assets to a non-owned, shared album (lots of notifications)
  • Remove own assets from a non-owned, shared album (new feature :tada:)
  • Remove a partner shared asset from a non-owned, shared album (via API confirmed no remove access without partner sharing and confirmed removed success with partner sharing)
  • Remove current thumbnail asset from album and verify new thumbnail is set
  • Remove last asset from album and verify album has null thumbnail

jrasm91 avatar Jul 04 '23 19:07 jrasm91

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 1, 2023 9:53pm

vercel[bot] avatar Jul 04 '23 19:07 vercel[bot]

@jrasm91 When you have time, can you help rebase this? I can look at this PR now

alextran1502 avatar Aug 01 '23 01:08 alextran1502

@jrasm91 When you have time, can you help rebase this? I can look at this PR now

Should be good to go now. Thanks.

jrasm91 avatar Aug 01 '23 16:08 jrasm91