immich icon indicating copy to clipboard operation
immich copied to clipboard

refactor(server): access permissions

Open jrasm91 opened this issue 2 years ago • 1 comments

Create an AccessCore where all asset, album, etc. access checks can be consolidated. Eventually, hopefully, this logic can be enhanced with additional modifiers (additional share settings set on the user, album, asset, api key, etc.)

jrasm91 avatar Jun 22 '23 03:06 jrasm91

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
immich ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 1:12am

vercel[bot] avatar Jun 22 '23 03:06 vercel[bot]

Issue 1

Not sure if this is related to this PR. In public shared links, drag and drop to upload returns forbidden status while clicking on the upload button to choose assets from the file explorer works.

Issue 2

Cosmetic - on the web, with shared link disabled download, while multi selection enabled, the app bar showed the download button, although it doesn't work.

Let me know if you want to address those two issues in this PR or we can do it in a subsequent one

alextran1502 avatar Jun 28 '23 01:06 alextran1502

I'd guess issue one and two are pre-existing, and if so they can be fixed in a separate PR. If they are new bugs I'll fix them obviously. Those are good finds though and I can probably take a look at fixing them soon.

jrasm91 avatar Jun 28 '23 02:06 jrasm91

I confirmed issue one and two exist in the demo site today, so they're not introduced with this PR.

jrasm91 avatar Jun 28 '23 12:06 jrasm91

Created these to track the two (existing) bugs you found:

  • #3005
  • #3006

jrasm91 avatar Jun 28 '23 12:06 jrasm91