immich
immich copied to clipboard
refactor(server): access permissions
Create an AccessCore where all asset, album, etc. access checks can be consolidated. Eventually, hopefully, this logic can be enhanced with additional modifiers (additional share settings set on the user, album, asset, api key, etc.)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| immich | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 28, 2023 1:12am |
Issue 1
Not sure if this is related to this PR. In public shared links, drag and drop to upload returns forbidden status while clicking on the upload button to choose assets from the file explorer works.
Issue 2
Cosmetic - on the web, with shared link disabled download, while multi selection enabled, the app bar showed the download button, although it doesn't work.
Let me know if you want to address those two issues in this PR or we can do it in a subsequent one
I'd guess issue one and two are pre-existing, and if so they can be fixed in a separate PR. If they are new bugs I'll fix them obviously. Those are good finds though and I can probably take a look at fixing them soon.
I confirmed issue one and two exist in the demo site today, so they're not introduced with this PR.
Created these to track the two (existing) bugs you found:
- #3005
- #3006