immich icon indicating copy to clipboard operation
immich copied to clipboard

Update Duplicate Upload UI (Web)

Open KotaUeshima opened this issue 2 years ago • 3 comments

Solution to - #2557

Description

This PR attempts to create UI update to show the user if one of the files that have been uploaded is a duplicate. This has been done by creating a new warning notification when a duplicate has been uploaded

Screen Shot 2023-06-18 at 10 18 52 PM

How has this been tested?

This was manually tested using different photos, and also uploading multiple photos at once, duplicates and non-duplicates.

Checklist

  • [x] Passed All Web Tests
  • [x] Passed Formatting Tests

KotaUeshima avatar Jun 19 '23 03:06 KotaUeshima

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Jun 19, 2023 3:28am

vercel[bot] avatar Jun 19 '23 03:06 vercel[bot]

And technically the photos will appear on refresh, because they're already added 😀

jrasm91 avatar Jun 19 '23 03:06 jrasm91

Thanks for the feedback! I guess I went for the warning notification with this message in case the user uploaded multiple pictures, therefore he/she would be notified that at least one of them was a duplicate. That is true, but I think because I say that "duplicate pictures will not refresh" it clarifies that only the "duplicates" will not appear.

KotaUeshima avatar Jun 20 '23 02:06 KotaUeshima

Hello @KotaUeshima, can you help address the review issue from Jason?

alextran1502 avatar Jul 01 '23 04:07 alextran1502

CLosing due to inactivity

alextran1502 avatar Jul 09 '23 02:07 alextran1502