immich
immich copied to clipboard
feat(mobile): new settings ui
Description
Redesigned settings pages with a more modern and eye-catching interface.
I have attached images in the Screenshots
Screenshots (if appropriate)
Checklist:
- [x] I have performed a self-review of my own code
- [x] I have made corresponding changes to the documentation if applicable
- [x] I have no unrelated changes in the PR.
- [x] I have confirmed that any new dependencies are strictly necessary.
- [x] I have written tests for new code (if applicable)
- [x] I have followed naming conventions/patterns in the surrounding code
Great work, I like the design a lot. There are a few things I would like to get your help with
-
Can you keep the original translation?
-
Make sure that the spacing is consistent
- This header looks out of place
-
Use the same style headers for all segments. For example, in Photo Grid, the first segment doesn't have a title. There should be one for consistency
-
In networking, there should be a spacing between the top segment and the app bar
-
In the backup option, you should use the same segment style as others
Hi @alextran1502
Regarding the points you mentioned, I'll address each one:
-
I will try to minimize changes to the original translations, but I have added some new translations for certain UI elements.
-
I fixed that issue in my last commit.
-
I changed the header color so it doesn't look out of place. Please see the image below—what do you think?
-
I think using the same header style for all segments would be challenging because each segment requires the appropriate icon and title. If you have any ideas, please share them.
-
I fixed that issue in my last commit.
-
I believe the current design for the backup option is good. If you want to use the same segment style, I can try changing it locally so you can better visualize it. What are your thoughts? If you like it or if you have new ideas, please let me know. I have attached images of the foreground backup with the segment style.
In my last commit, I changed the card's background color have more white and reduced the border width. Do you like it?
Let me know your thoughts. Thank you!
Hi Thien,
- We are using all capital letters here, so ideally, the font size should be smaller, try 13 or 14
- You can make them with a header with a title as "Placeholder", I can go through and come up with an appropriate one
- Yeah, I like the new option. I wonder if we can swap out the elevated button for a switch like other toggleable options in the settings
In my last commit, I changed the card's background color have more white and reduced the border width. Do you like it?
Looks good, when I go through the final tests, I can make small adjustments if needed
Hi @alextran1502,
I have made the changes per your suggestions. I have also added a header titled "Placeholder" for all sections. Please review it when you have time.
Additionally, I have a new design for the backup page. Please see the image below.
Hi @alextran1502,
Everything has been completed for you to review in the last two commits. If you find it difficult to review, I can revert those changes and create a separate pull request.
-
In the first commit, I split the settings into smaller widgets so that unrelated widgets are not rebuilt and the code logic is easier to understand.
-
In the second commit, I tried a new font and found it very suitable for the application. I pushed it for you to review—if you like it, please let me know.
Have a nice day, Thanks
Hi @dvbthien, please keep this PR containing the new design for the settings stuff. Other refactoring should be in their PRs.
Regarding the fonts, I would like to make this change when needed. It is an important factor in the whole app's look and feel
Hi @alextran1502,
I have reverted the commits. Please review them when you have a moment.
Regarding the Mulish font, I find it very similar to Overpass. I think it's beautiful, comfortable, and easy to read. You can try it out when you have time
Thanks
This had a lot of back and forth, but I'm not sure what the status is now. There are a lot of merge conflicts so I'm going to close this as stable. If this is something we want to merge, we'll need to rebase the changes and ping Alex to give it another round of review.