immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(mobile): Responsive list and grid view of backup album selection and fixes search filter

Open martyfuhry opened this issue 2 years ago • 6 comments

ListView

When the viewport is narrow (small width), show the ListView: image

GridView

When the viewport is wide (large width), show the GridView image

martyfuhry avatar Feb 28 '23 15:02 martyfuhry

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Feb 28, 2023 at 9:31PM (UTC)

vercel[bot] avatar Feb 28 '23 15:02 vercel[bot]

Can we align the selection info title and the chips to the left? Thank you

alextran1502 avatar Feb 28 '23 15:02 alextran1502

Can we align the selection info title and the chips to the left? Thank you

Done.

martyfuhry avatar Feb 28 '23 15:02 martyfuhry

I noticed a bug while testing this in Search, but I'm not sure if it was introduced by this patch or part of the stable version.

  • Search for an album (e.g., Recent) by typing in the search query
  • The searched for album filters out the rest of the list and is the only resultant with the rest of the albums filtered and not visible
  • Delete your search text so you only have an empty search bar
  • The rest of the albums do not reappear; they remain filtered

The expected result is for all of the albums to appear again. Did I mess this up or is this a known bug?

martyfuhry avatar Feb 28 '23 16:02 martyfuhry

@martyfuhry It is a known bug or the bug you just discovered, not from the result of your PR. Do you think you can fix the bug in this PR as well?

alextran1502 avatar Feb 28 '23 16:02 alextran1502

@martyfuhry It is a known bug or the bug you just discovered, not from the result of your PR. Do you think you can fix the bug in this PR as well?

Fixed! Try it out.

martyfuhry avatar Feb 28 '23 16:02 martyfuhry