immich icon indicating copy to clipboard operation
immich copied to clipboard

refactor(server): use exiftool for file date metadata

Open mertalev opened this issue 9 months ago • 1 comments

Description

There are two redundant stat calls in metadata extraction that can instead use the exiftool output (tags starting with File are from the file system). Besides generally less file IO, it avoids taking up a thread (or waiting to acquire one) in the all-too-limited libuv threadpool. Based on #16450, which should be merged first.

I tested locally and it works as expected. However, there are cases in the library E2E tests where the tags are undefined. I don't know why this is. The PR falls back to calling .stat in this case to handle this.

This is the last of the PRs split off from #14277.

mertalev avatar Mar 01 '25 11:03 mertalev

Throwing copilot reviewer at this as a test

zackpollard avatar Mar 03 '25 12:03 zackpollard

Can you help resolve conflict? I can help with another round of testing

alextran1502 avatar Mar 06 '25 15:03 alextran1502

Conflicts are resolved

mertalev avatar Mar 06 '25 15:03 mertalev