immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(server/web): Initial support for RAF and SRW RAW formats

Open samip5 opened this issue 2 years ago • 4 comments

Fixes #1367 Fixes #1368

samip5 avatar Jan 24 '23 23:01 samip5

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
immich-code-coverage ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 14, 2023 at 7:34PM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
immich ⬜️ Ignored (Inspect) Feb 14, 2023 at 7:34PM (UTC)

vercel[bot] avatar Jan 24 '23 23:01 vercel[bot]

@samip5 is attempting to deploy a commit to the immich Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Jan 24 '23 23:01 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 5 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Feb 02 '23 09:02 vercel[bot]

Deployment failed with the following error:

Resource is limited - try again in 4 hours (more than 100, code: "api-deployments-free-per-day").

vercel[bot] avatar Feb 02 '23 10:02 vercel[bot]

@samip5 Can you rebase with main and keep the fallback implementation on generating thumbnails?

The frontend is handled by https://github.com/immich-app/immich/pull/1570. You can add the file type for RAF and SRW to the list of file name to infer its mimetype

alextran1502 avatar Feb 09 '23 16:02 alextran1502

Can you rebase with main and keep the fallback implementation on generating thumbnails?

Rebased.

samip5 avatar Feb 09 '23 18:02 samip5

@alextran1502 & @jrasm91 What's the status of this? What should I do to get it merged?

samip5 avatar Feb 13 '23 12:02 samip5

@samip5 Ah crap, I forgot about this one. Let me run some quick tests today and get it merged

alextran1502 avatar Feb 13 '23 12:02 alextran1502

@samip5 Ah crap, I forgot about this one. Let me run some quick tests today and get it merged

It seems there's more merge conflicts again, gonna fix those and probably then it could be merged?

samip5 avatar Feb 14 '23 15:02 samip5

@samip5 Can you help fix the linter issue so we can merge it in?

alextran1502 avatar Feb 14 '23 17:02 alextran1502

@samip5 Can you help fix the linter issue so we can merge it in?

I had ran prettier, and it doesn't complain of any issues on my end.

samip5 avatar Feb 14 '23 19:02 samip5

@samip5 Here is the failed test case

image

alextran1502 avatar Feb 14 '23 19:02 alextran1502

@samip5 I helped you push the fix

alextran1502 avatar Feb 14 '23 19:02 alextran1502

Ah, my local prettier was not complaining at all despite that test.

samip5 avatar Feb 14 '23 19:02 samip5