immich icon indicating copy to clipboard operation
immich copied to clipboard

chore(web): migration svelte 5 syntax

Open alextran1502 opened this issue 1 year ago • 3 comments
trafficstars

alextran1502 avatar Nov 02 '24 18:11 alextran1502

The first round of testing is done, these are the isssues I found:

  • Album share: adding/removing users not correctly updated
  • Adding assets to empty album: select photos stays visible
  • Some confirm prompts have generic message "Are you sure you want to to this?"
  • Asset detail panel: adding a location throws error
  • Select assets > add/remove favorite: no longer updates the icon
  • Description doesn't update when navigating between assets
  • Saving slideshow settings freezes browser
  • Album options/settings > comment & likes: cannot be disabled

Thanks Michel for testing, I fixed all the issues except Adding assets to empty album: select photos stays visible as I cannot reproduce it.

alextran1502 avatar Nov 10 '24 23:11 alextran1502

I also can't reproduce it, so it was probably fixed. I've done some more testing and there are still a few issues:

  • Using shift to select multiple assets doesn't work
  • Updating asset info in the detail panel reloads the asset viewer (only panorama or video)
  • Asset description has incorrect height with long text
  • Asset change location: search places input is gone
  • User settings: notification updates are saved twice
  • Layout of /admin/repair page is broken

michelheusschen avatar Nov 11 '24 07:11 michelheusschen

@michelheusschen Fixed the issue with merging people on people page. The updating asset info reset the asset viewer for panoramas is currently on main. So we can probably fix that in a different PR since it is not a blocker for this PR

alextran1502 avatar Nov 13 '24 20:11 alextran1502