immich
immich copied to clipboard
immich-app
feat(web): Add Partner Sharing Avatars to Timeline and Info Cards
This Feature adds user avatars to the timeline for both partner sharing, and shared albums.
Timeline
The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name.
(In the screenshot below, the partner's icon is an Orange 'T'). Implements a simple store for user data to efficiently pull user data for the timelines.
New Settings
In order to control this feature there is a new setting added in the sharing config (changed from partner sharing to generic sharing).
Asset View
Additionally, there is improvements to the asset view to make it clear the source of the image (either shared, when in an album, or from partner sharing in the main timeline)
Is the companion feature for the same capability set on the mobile app #12089
Implements Feature Request https://github.com/immich-app/immich/discussions/7608
Resolved all merge conflicts and test cases. Ready to merge. (Apologies for opening and reopening)
Maybe it should be placed under Partner Sharing?
Agreed, updated the PR description with the new placement. Swapped out the Partner Sharing title to a generic Sharing configuration, and then moved partners into an accordion box. Allow for future sharing specific settings to be added in the future.
Maybe it should be placed under Partner Sharing?
Agreed, updated the PR description with the new placement. Swapped out the Partner Sharing title to a generic Sharing configuration, and then moved partners into an accordion box. Allow for future sharing specific settings to be added in the future.
Looks good I like that, but it's not my job to decide so let's see what the opinion of the core development team is.
