immich icon indicating copy to clipboard operation
immich copied to clipboard

Published 20 hours ago • verified publisher icon immich-app

feat(web): revamp places

Open kvalev opened this issue 1 year ago • 4 comments

Description

The Places page has been slightly revamped as follows:

  • Added a counter for number of places
  • Added a search box for filtering places
  • Added places grouping: default is no grouping, but the cities can be grouped by country (similarly to how the albums are grouped by year). When searching for places, empty groups will be hidden. If places are grouped, then icons for expanding or collapsing all will be shown.

Open points/questions:

  • ~~currently the country/group counter says N Albums instead of N Places, but I havent figured out the translations yet~~
  • part of the grouping dropdown is outside the screen when no grouping has been selected
  • translations?!?
  • tests?!?

Screenshots

Default view places-default-view
Grouped (looks a bit dumb on the demo server, as there is usually only 1 place per country) places-grouped
Grouped and collapsed places-collapsed
Grouped and filtered places-filtered

fixes #2631

kvalev avatar Sep 01 '24 20:09 kvalev

image

Thank you for the PR, looks great! What is the count here? I assume it means one place for the country, not an album, correct?

alextran1502 avatar Sep 01 '24 21:09 alextran1502

Thank you for the PR, looks great! What is the count here? I assume it means one place for the country, not an album, correct?

Yeah exactly, this should be the number of places for the given country, but currently it says albums, as I havent figured out the translations, so I reused the one from the albums page :D

kvalev avatar Sep 01 '24 21:09 kvalev

The label should be correct now, at least in English, I havent added any translations:

places-fixed-translations

kvalev avatar Sep 01 '24 21:09 kvalev

Hello, I run into this issue while trying to change the grouping

image

alextran1502 avatar Oct 09 '24 16:10 alextran1502

Closing as no response to feedback, please feel free to re-open a new PR or comment on this one if you are planning to continue work on this in the future! 😄

zackpollard avatar Nov 13 '24 01:11 zackpollard

👋 I am back from traveling and can pick up where I left off. Would you mind reopening the PR?

kvalev avatar Dec 19 '24 01:12 kvalev

I rebased the PR and checked that there are no errors in the console. Can you take another look? I cant figure out how to fix the layout problem when no grouping is selected, but I am hoping one of you has an idea.

kvalev avatar Jan 26 '25 09:01 kvalev