immich
immich copied to clipboard
immich-app
feat(mobile): Add Partner Sharing Avatars to Timeline and Info Cards
This Feature adds user avatars to the timeline for both partner sharing, and shared albums. The avatar uses the user's avatar image (if one is set) or the server's information is used to make an avatar using the user's assigned color and first letter of their name. (In the screenshot below, the partner's icon is an Orange 'T')
This is an optional configuration that adds a new setting in the Photo Grid section of the settings.
Additionally, storage information is now shown in the image details card. For partner sharing it will show which partner it belongs to. For other images, it provides a text description and existing storage icons if the photo is local, remote, or merged (backed up). This can be useful if the storage icons are hidden.
I am working on implementing a similar feature set on the web app to ensure consistent experience
Implements https://github.com/immich-app/immich/discussions/7608 (actually for the web but the original PR publisher writes that he will consider a web version)
aviv926
Yeah, the plan was to put mobile and web together in one PR but ran into some issues getting it done efficiently on the web side, so I split the work. Should have the web implementation done shortly, and that would implement #7608 almost exactly like you mocked it up.
PR https://github.com/immich-app/immich/pull/12413 implements the same feature set on web.
Just curious, but is this feature still not available? I haven't seen any indication of who uploaded what to a shared album. Would be a nice addition. :)
Just curious, but is this feature still not available? I haven't seen any indication of who uploaded what to a shared album. Would be a nice addition. :)
@scrampker Just updated the PR to incorporate the changes made in the mobile app as of 1.18. Should be good to merge (pending review).
Just need a maintainer to tag it and then review it :)
Hello, thank you for the PR. I just ran testing on this PR. A few points
- Turn off "Show user thumbnails" in the App Settings doesn't take effect.
- ~~I would like to have this mechanism disabled by default.~~ Actually, having it on by default is nice.
- In the asset viewer, putting the users' avatar on the top app bar looks strange. I think having the information inside the detail panel is enough
Hello, thank you for the PR. I just ran testing on this PR. A few points
- Turn off "Show user thumbnails" in the App Settings doesn't take effect.
- ~I would like to have this mechanism disabled by default.~ Actually, having it on by default is nice.
- In the asset viewer, putting the users' avatar on the top app bar looks strange. I think having the information inside the detail panel is enough
Nice catch on the settings issue, and I do agree user avatar at the top is a bit out of place (since everything else up there is an action). I think there is enough context clues (like missing download and favorite icons) to indicate if an image is being shared.
Is a part of this feature set to "add to library?" If someone uploads to a shared, and you want it to be added to your main view. IE if the shared album is deleted or the user removes their assets.
@x24git Apologies for the lack of update and thanks a lot for the contribution. Can you please rebase it over main and we can check and get this merged?
