immich icon indicating copy to clipboard operation
immich copied to clipboard

feat: tags

Open jrasm91 opened this issue 1 year ago • 7 comments

Add support for xmp tags.

TODO:

  • Write tags to sidecar
Screenshots
Description Image
Sidebar image
Explorer image
Tag assets action image
Create tag image

jrasm91 avatar Aug 22 '24 19:08 jrasm91

Closes #2168, #3518, #3950.

bo0tzz avatar Aug 22 '24 19:08 bo0tzz

Are tag edits applied to the picture file? It's nicer if the file itself is modified instead of putting metadata in a sidecar file (which you then have to delete once you apply the metadata to the file with Digikam).

briandipalma avatar Aug 23 '24 07:08 briandipalma

The tags are stored in the database, not sidecars, nor in the assets themselves.

C-Otto avatar Aug 23 '24 08:08 C-Otto

The tags are stored in the database, not sidecars, nor in the assets themselves.

oh really? so we cant edit them outside of immich at all with digikam for example? what is with xmp tags created with other software before import? will it import those to immich?

mtojay avatar Aug 23 '24 08:08 mtojay

Tags that exist in the file's metadata are imported. This is just a first pass at the feature (and it's still in draft!), writing tags can be added later.

It's nicer if the file itself is modified instead of putting metadata in a sidecar file

We fundamentally never make changes to the original file.

bo0tzz avatar Aug 23 '24 09:08 bo0tzz

I don't get why you wouldn't write metadata to the file. This isn't darktable it's not about editing the picture, it's more like Digikam, for categorizing pictures and it writes metadata to the picture file. I find it annoying when I change a date on a file and if I copy the file my edits aren't in the file metadata. My categorizing work has effectively been thrown out.

briandipalma avatar Aug 23 '24 12:08 briandipalma

Please don't bring over to this PR the debate of sidecar vs originals, which has already been answered several times elsewhere. This discussion should be centered around the technical implementation of the feature. The major design decision have already been made:

  • Read tags from xmp
  • Write tags to xmp
  • Dedicated tag table
  • Many to many between assets and tags
  • Tag explorer
  • Viewing parent tag implies seeing assets linked to all children
  • View tags in asset detail panel
  • Add new tags
  • Delete existing tags
  • Add/remove tags in bulk via mult-select option
  • Eventually add multiple tags at once to a set of assets

jrasm91 avatar Aug 23 '24 16:08 jrasm91

Would it be possible to add option item for Tags and Folders to hide those from Library section same as for People and Sharing? They take up space at the expense of the storage and version info below on small screens.

waclaw66 avatar Aug 29 '24 18:08 waclaw66

@waclaw66 yep, see #12099

alextran1502 avatar Aug 29 '24 18:08 alextran1502

Please pay attention #12165

ilyaChuk avatar Aug 30 '24 22:08 ilyaChuk

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files?

I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

Knuppel1983 avatar Oct 07 '24 13:10 Knuppel1983

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files?

I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

It writes the tags to an XMP sidecar file, just like any other metadata you change within immich

danieldietzler avatar Oct 07 '24 13:10 danieldietzler

Does this feature write the tags to the original files? If not can this be added as an option? Or an option to export the tags with the original files? I want my photo library to be vendor-independant, so i can import / export without having to tag everything all over again...

It writes the tags to an XMP sidecar file, just like any other metadata you change within immich

Ok that will do. Please also add an option to disable smart search, and search by tag only. Some of us don't need machine learning, and it puts a lot of strain on low powered devices.

Knuppel1983 avatar Oct 07 '24 16:10 Knuppel1983

@Knuppel1983 you can already do this from the admin settings.

image

jrasm91 avatar Oct 07 '24 19:10 jrasm91