immich icon indicating copy to clipboard operation
immich copied to clipboard

fix(mobile): consider manual upload when darkening screen

Open Saschl opened this issue 1 year ago • 2 comments

Changes:

I noticed the manual upload was not considered in the current logic. Added a simple check to also apply the mechanism to the manual uploads/backups (hopefully the last change for this functionality :D )

Saschl avatar Aug 19 '24 20:08 Saschl

Usually, for manual upload, I don't expect the user to leave the phone open for long. So I don't think we need this mechanism here, to keep the logic simple

alextran1502 avatar Aug 25 '24 05:08 alextran1502

Usually, for manual upload, I don't expect the user to leave the phone open for long. So I don't think we need this mechanism here, to keep the logic simple

I see your point, just thought it would be more consistent and a bit less confusing to the user as the behaviour on the backup page would be the same then.

But your call in the end 👍

Saschl avatar Aug 25 '24 09:08 Saschl

Closing this PR per the previous comment. Thanks for opening it

alextran1502 avatar Oct 09 '24 16:10 alextran1502