feat(web): Edit people - Start people search on key press

[Jan108]

When editing a face, I often need to search for the right one. And I found myself quite often starting to type the name of the person before I click on the Search icon. So I added the functionality that, when selecting a new person for a face and starting to type, it starts the search automatically, instead of first clicking on the search icon. No functionality is removed, only added.

Before:

With this change:

[michelheusschen]

I agree with Martin, it's unexpected for the search input to suddenly activate and it conflicts with existing shortcuts (like f for favorite). Maybe the shortcut Ctrl + k can be used for consistency with the search bar.

[Jan108]

I just want to streamline a face change process, and I find it pretty intuitive to start the search when typing. But I also understand why you would prefer a shortcut. My intention was to reduce the amount of inputs for changing a face from 3 clicks and search to 2 clicks and search. A shortcut to select the search bar won't help there, because it won't reduce the amount of steps.

If we want to use a shortcut, it should work on the default photoviewer and directly open the new face selection, with possibly selecting the search bar. But I can't think of a good way to determine which face should be edited (mouse hover or tab selection comes to my mind, but both seem unintuitive for the user).

[jrasm91]

It's pretty common for the / key to focus on the search input. Thoughts on that instead?

[Jan108]

I thought a little more how to streamline the process, and here are my proposed changes:

• Add a shortcut p to the photoviewer to open the edit people side panel
• Alter the tabindex on the edit-people side panel, so that it starts with the first person and loops through the rest. On enter open the assign-face side panel for the selected person (Currently it would open the person page)
• Add the bounding boxes to the assign-face side panel, so the user knows which face is selected for the edit
• Add the shortcut / and - (KeyCode: 173, but difference in qwerty/qwertz) to select the search input
• Alter the tabindex on the assign-face side panel to loop thought the search results and select with enter
• Maybe: Add the shortcut n to the assign-face side panel to create a new face

[aviv926]

I liked this feature it could be looking to repeatedly press the search or a keyboard shortcut when doing it for a quantity of images, maybe it could be user selectable under system interface settings?

[alextran1502]

Hello, what is the status of this PR?

[Jan108]

Hi, initially I waited for a little feedback to my proposal. Because nobody had any complains, I started implementing, but then life got in the way and I didn't finish. I think I will get to it this week or next :)

[github-actions[bot]]

Label error. Requires exactly 1 of: changelog:.*. Found: 🖥️web

[jrasm91]

This PR is quite old now and hasn't had much movement, so I'm going to go ahead and close it.