immich icon indicating copy to clipboard operation
immich copied to clipboard

feat(server): add env to define the path of build-lock.json

Open martabal opened this issue 1 year ago • 6 comments
trafficstars

This PR adds an env to define the path of build-lock.json

martabal avatar Jul 03 '24 16:07 martabal

Is there a reason why you can't just read this from the CWD?

Yes, we don't use relative path, only absolute paths

martabal avatar Jul 03 '24 16:07 martabal

Is there a reason why you can't just read this from the CWD?

Yes, we don't use relative path, only absolute paths

What are you going to set it to?

jrasm91 avatar Jul 03 '24 16:07 jrasm91

What are you going to set it to?

Probably /app/immich/server/build-lock.json

martabal avatar Jul 03 '24 16:07 martabal

Hello, have you tested this in the production build?

alextran1502 avatar Jul 03 '24 17:07 alextran1502

Hello, have you tested this in the production build?

Hi! I built the base-image locally and ran the production build. It's running fine.

root@d98d644d1c6e:/usr/src/resources# ls -la
total 24
drwxr-xr-x 1 root root 4096 Jul  3 20:19 .
drwxr-xr-x 1 root root 4096 Jul  3 20:11 ..
-rw-r--r-- 1 root root  694 Jun 30 13:08 build-lock.json
drwxr-xr-x 2 root root 4096 Jul  3 20:13 geodata
drwxr-xr-x 3 root root 4096 Jul  3 20:19 www

martabal avatar Jul 03 '24 18:07 martabal

Closing in favor of #10958.

jrasm91 avatar Jul 08 '24 18:07 jrasm91