immer icon indicating copy to clipboard operation
immer copied to clipboard

Published 20 hours ago • verified publisher icon immerjs

Do not replace array.length

Open kshramt opened this issue 3 years ago • 2 comments
trafficstars

Patches generated by the current implementation do not follow the RFC method for removing an element from an array (https://www.rfc-editor.org/rfc/rfc6902#page-13) and cannot be used from other languages (e.g., https://pypi.org/project/jsonpatch/).

kshramt avatar Jul 31 '22 14:07 kshramt

Deploy Preview for quizzical-lovelace-dcbd6a canceled.

Name Link
Latest commit 503b4be26f74db3b76c6a192c6d8bc91c2d99a00
Latest deploy log https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/62e694b0eace7d0009cb9481

netlify[bot] avatar Jul 31 '22 14:07 netlify[bot]

https://github.com/immerjs/immer/issues/208#issuecomment-996064385 might be resolved by the PR.

kshramt avatar Jul 31 '22 15:07 kshramt

Thanks for this PR! Apologies for the slow follow up, I do intend to merge, but as a separate major version.

mweststrate avatar Jan 15 '23 16:01 mweststrate

Branch has been merged manually into #1028, thanks!

mweststrate avatar Mar 23 '23 19:03 mweststrate