Jason Hall

Results 520 comments of Jason Hall

> Well that seems nice and easy 👍 Integration tests fail while I'm using `packages.Load` instead of shelling out to `go list` -- I'll either figure it out, or just...

Maybe helpful: https://pkg.go.dev/golang.org/x/tools/go/buildutil#ExpandPatterns

I still think this is worth doing, and https://github.com/google/ko/pull/665 seems pretty close to being ready. Keeping this open in the meantime.

This doesn't seem related to 1.18, but rather `ko`'s dep on cosign, which is fairly old at 1.3.1 (current is 1.8.0). Between those two versions, the const was renamed. #718...

> Thanks. This is from `tools` module. Our tooling is built around tooling module changing that and installing `ko` would be a significant change. > > I see a PR...

cc @squillace 👀

> I tried to declutter the build package a bit to provide a more readable structure. The current build package is huge and it's hard to understand what build (building...

Throwback to https://github.com/google/ko/issues/221

And https://github.com/google/ko/issues/366 -- gosh, I've wanted this for a while. 🙃

`ko publish` doesn't fail, so e2e tests on Windows didn't care. This sounds like it may also be a gap in e2e tests, we should consider adding a `cosign download...