fix: source width and height HTML validation - bug #860

[val3ntin]

trafficstars

Description

this fixes https://github.com/imgix/react-imgix/issues/860 issue when HTML source tag does not pass the validation due to width/height presence in DOM

Checklist

Please use the checklist that is most closely related to your PR (you only need to use one checklist, and you can skip items that aren't applicable or don't make sense):

• bug fix

Bug Fix

• [x] All existing unit tests are still passing (if applicable)
• [x] Add new passing unit tests to cover the code introduced by your PR
• [ ] Update the readme
• [ ] Update or add any necessary API documentation
• [ ] Add some steps so we can test your bug fix
• [ ] The PR title is in the conventional commit format: e.g. fix(<area>): fixed bug #issue-number
• [ ] Add your info to the contributors array in package.json!

Steps to Test

A code example or a set of steps is preferred.

Related issue: #860

[commit-lint[bot]]

Bug Fixes

• source width/height HTML validation (25a5158)

Contributors

val3ntin

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

• @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
• @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
• @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
• @Commit-Lint merge disable will desactivate merge dependabot PR
• @Commit-Lint review will approve dependabot PR
• @Commit-Lint stop review will stop approve dependabot PR

[sherwinski]

Hey @val3ntin and thanks for opening this PR! I've made a note to test this out locally in the next week or so when I get a bit more time. I'll follow up with any questions here if I have any.

[luqven]

Hey @val3ntin, apols for the delay. We had some high-priority items that came up which took our eye off the ball here.

Would you mind updating this branch? Merge or rebase with/on main is fine. If you no longer have the time I'm happy to take this over.

[luqven]

Thanks, @val3ntin!

Everything LGTM but I'm going to cut a release candidate on beta first to smoke test any unforeseen issues. If all goes well, we'll merge beta into main.

[imgix-git-robot]

:tada: This PR is included in version 9.5.3-beta.1 :tada:

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: