ledclock icon indicating copy to clipboard operation
ledclock copied to clipboard

Published 20 hours ago • verified publisher icon imeszaros

How can I change the number of LEDs / order of LEDs?

Open imeszaros opened this issue 3 years ago • 63 comments
trafficstars

For versions >= 1.3.0

Please check const_ledclock.h for instructions.

For versions < 1.3.0:

If you want to change how many LEDs make up a segment:

  • change the total number of LEDs in platformio_override.ini:
  • in um_ledclock.h change in the member initializer list the arguments for dHoursT, dHoursO, dMinutesT and dMinutesO from 2 to the desired number of LEDs per segment
  • currently it is not possible to change the number of LEDs in the separator

Either if you've changed the number of LEDs or just want to change the order of LEDs, you need to re-map the LEDs here:

  • For example the statement dHoursT.mapSegment(_7SEG_SEG_A, 6, 7); maps the 'A' segment of the 'tens' digit to LEDs indexed with 6 and 7.
  • mapSegment(...) can be called with variable number of arguments depending on how many LEDs you have per segment.
  • mapSegment(...) expects LED ordering within a segment:
    • left to right for horizontal segments (e.g. A)
    • top to bottom for vertical segments (e.g. B)

EDIT: about the mapping of the separator, read this.

imeszaros avatar Oct 03 '22 14:10 imeszaros

so I am doing something different and trying to edit all this, but the sep.map is confusing to me(noob sorry) my led string is a 30 led string so there is only 1 led in each segment and there is 2 leds in the separator. but I dont understand what the numbers in the sep.map means. the leds would be numbers 14 and 15. This is what I have it look like now, but I dont know what to change sep.map to. would I just change 29/28 to 14 15?

`void setup() {
    // digit 1
    dHoursT.setShowZero(!hideZero);
    dHoursT.mapSegment(_7SEG_SEG_A, 2);
    dHoursT.mapSegment(_7SEG_SEG_B, 1);
    dHoursT.mapSegment(_7SEG_SEG_C, 6);
    dHoursT.mapSegment(_7SEG_SEG_D, 5);
    dHoursT.mapSegment(_7SEG_SEG_E, 4);
    dHoursT.mapSegment(_7SEG_SEG_F, 3);
    dHoursT.mapSegment(_7SEG_SEG_G, 0);

    // digit 2
    dHoursO.mapSegment(_7SEG_SEG_A, 9);
    dHoursO.mapSegment(_7SEG_SEG_B, 8);
    dHoursO.mapSegment(_7SEG_SEG_C, 13);
    dHoursO.mapSegment(_7SEG_SEG_D, 12);
    dHoursO.mapSegment(_7SEG_SEG_E, 11);
    dHoursO.mapSegment(_7SEG_SEG_F, 10);
    dHoursO.mapSegment(_7SEG_SEG_G, 7);

    sep.map(2,
        2, 0, 29,
        4, 0, 28);

    // digit 3
    dMinutesT.mapSegment(_7SEG_SEG_A, 18);
    dMinutesT.mapSegment(_7SEG_SEG_B, 17);
    dMinutesT.mapSegment(_7SEG_SEG_C, 22);
    dMinutesT.mapSegment(_7SEG_SEG_D, 21);
    dMinutesT.mapSegment(_7SEG_SEG_E, 20);
    dMinutesT.mapSegment(_7SEG_SEG_F, 19);
    dMinutesT.mapSegment(_7SEG_SEG_G, 16);

    // digit 4
    dMinutesO.mapSegment(_7SEG_SEG_A, 25);
    dMinutesO.mapSegment(_7SEG_SEG_B, 24);
    dMinutesO.mapSegment(_7SEG_SEG_C, 29);
    dMinutesO.mapSegment(_7SEG_SEG_D, 28);
    dMinutesO.mapSegment(_7SEG_SEG_E, 27);
    dMinutesO.mapSegment(_7SEG_SEG_F, 26);
    dMinutesO.mapSegment(_7SEG_SEG_G, 23);`

littleferris avatar Feb 01 '23 22:02 littleferris

@littleferris You're right, there was no word about the separator in the OP.

The idea is that the 7 segment displays and the separator together create an imaginary two dimensional display. The number of rows and columns of this display depends on how many leds a segment of a 7 segment display has.

For example, if the whole display would only stand of one 7 segment display, its 'pixels' could be addressed like:

//     x (0,1..n) x
//   (1,0) x x (1,n+1)
//   (2,0) x x (2,n+1)
//     x (3,1..n) x
//   (4,0) x x (4,n+1)
//   (5,0) x x (5,n+1)
//     x (6,1..n) x

The first argument of the separators map function tells how many leds it has (e.g. 2). Then for each LED comes a row and a column index and finally a LED index.

The separator display in my case only has one 'column', so the column index is zero for both LEDs (indices are local to the 'display part'). Since I use 2 leds per segment, my separator is 7 'pixel' high, and I positioned the LEDs above and below the center segment of the 7 segment displays:

//     x (0,1..n) x
//   (1,0) x x (1,n+1)
//   (2,0) x x (2,n+1)  here row = 2
//     x (3,1..n) x
//   (4,0) x x (4,n+1)  here row = 4
//   (5,0) x x (5,n+1)
//     x (6,1..n) x

sep.map(2 // 2 leds,
  /*row: */ 2, /* col: */ 0, /* led: */ 29,
  /*row: */ 4, /* col: */ 0, /* led: */ 28);

I hope this helps!

imeszaros avatar Feb 02 '23 08:02 imeszaros

thanks . i changed the order of leds its working. please anyone tell me how to change time zone stuff in code and auto brightness off it would be helpfull

DJprasenjit avatar Feb 06 '23 04:02 DJprasenjit

Hi, I built the 4-display clock with 7 segments and two separators, each segment has 9 LEDs, I tried to change the parameters as you showed in the example, but I couldn't get anything done. this is what i wrote:

void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.4mapSegment(_7SEG_SEG_A, 27 , 28 , 29 , 30 , 31 , 32 , 33 , 34 , 35); dHoursT.5mapSegment(_7SEG_SEG_B, 36 , 37 , 38 , 39 , 40 , 41 , 42 , 43 , 44); dHoursT.7mapSegment(_7SEG_SEG_C, 54 , 55 , 56 , 57 , 58 , 59 , 60 , 61 , 62); dHoursT.1mapSegment(_7SEG_SEG_D, 8 , 7 , 6 , 5 , 4 , 3 , 2 , 1 , 0); dHoursT.2mapSegment(_7SEG_SEG_E, 17 , 16 , 15 , 14 , 13 , 12 , 11 , 10 , 9); dHoursT.3mapSegment(_7SEG_SEG_F, 26 , 25 , 24 , 23 , 22 , 21 , 20 , 19 , 18); dHoursT.6mapSegment(_7SEG_SEG_G, 53 , 52 , 51 , 50 , 49 , 48 , 47 , 46 , 45);

    // digit 2
    dHoursT.setShowZero(!hideZero);
    dHoursT.11mapSegment(_7SEG_SEG_A, 90 , 97 , 92 , 93 , 94, 95 , 96 , 97 , 98);
    dHoursT.12mapSegment(_7SEG_SEG_B, 99 , 100 , 101 , 102 , 103 , 104 , 105 , 106 , 107);
    dHoursT.14mapSegment(_7SEG_SEG_C, 117 , 118 , 119 , 120 , 121 , 122 , 123 , 124 , 125);
    dHoursT.8mapSegment(_7SEG_SEG_D, 71 , 70 , 69 , 68 , 67 , 66 , 65 , 64 , 63);
    dHoursT.9mapSegment(_7SEG_SEG_E, 80 , 79 , 78 , 77 , 76 , 75 , 74 , 73 , 72);
    dHoursT.10mapSegment(_7SEG_SEG_F, 89 , 88 , 87 , 86 , 85, 84 , 83 , 82 , 81);
    dHoursT.13mapSegment(_7SEG_SEG_G, 116 , 115 , 114 , 113 , 112 , 111 , 110 , 109 , 108);
   
    // addLed must be called LC_SEP_LEDS times
    sep.addLed(2, 0, 126);
    sep.addLed(4, 0, 127);
  
    // digit 3
    dHoursT.setShowZero(!hideZero);
    dHoursT.18mapSegment(_7SEG_SEG_A, 155 , 156 , 157 , 158 , 159, 160 , 161 , 162 , 163 );
    dHoursT.19mapSegment(_7SEG_SEG_B, 164 , 165 , 166 , 167 , 168 , 169 , 170 , 171 , 172 );
    dHoursT.21mapSegment(_7SEG_SEG_C, 182 , 183 , 184 , 185 , 186 , 187 , 188 , 189 , 190 );
    dHoursT.15mapSegment(_7SEG_SEG_D, 136 , 135 , 134 , 133 , 132 , 131 , 130 , 129 , 128 );
    dHoursT.16mapSegment(_7SEG_SEG_E, 145 , 144 , 143 , 142 , 141, 140 , 139 , 138 , 137 );
    dHoursT.17mapSegment(_7SEG_SEG_F, 154 , 153 , 152 , 151 , 150 , 149 , 148 , 147 , 146 );
    dHoursT.20mapSegment(_7SEG_SEG_G, 181 , 180 , 179 , 178 , 177 , 176 , 175 , 174 , 173 );
   
    // digit 4
    dHoursT.setShowZero(!hideZero);
    dHoursT.25mapSegment(_7SEG_SEG_A, 218 , 219 , 220 , 221 , 222, 223 , 224 , 225 , 226 );
    dHoursT.26mapSegment(_7SEG_SEG_B, 227 , 228 , 229 , 230 , 231 , 232 , 233 , 234 , 235 );
    dHoursT.28mapSegment(_7SEG_SEG_C, 245 , 246 , 247 , 248 , 249 , 250 , 251 , 252 , 253 );
    dHoursT.22mapSegment(_7SEG_SEG_D, 199 , 198 , 197 , 196 , 195, 194 , 193 , 192 , 191 );
    dHoursT.23mapSegment(_7SEG_SEG_E, 208 , 207 , 206 , 205 , 240 , 203 , 202 , 201 , 200 );
    dHoursT.24mapSegment(_7SEG_SEG_F, 217 , 216 , 215 , 214 , 213 , 212 , 211 , 210 , 209 );
    dHoursT.27mapSegment(_7SEG_SEG_G, 244 , 243 , 242 , 241 , 240 , 239 , 238 , 237 , 236 );

grazie mille

dipietrofilippo avatar May 01 '23 15:05 dipietrofilippo

I want to do the same…9 LEDs per segment Do you have a solution ?

Hi, I built the 4-display clock with 7 segments and two separators, each segment has 9 LEDs, I tried to change the parameters as you showed in the example, but I couldn't get anything done. this is what i wrote:

void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.4mapSegment(_7SEG_SEG_A, 27 , 28 , 29 , 30 , 31 , 32 , 33 , 34 , 35); dHoursT.5mapSegment(_7SEG_SEG_B, 36 , 37 , 38 , 39 , 40 , 41 , 42 , 43 , 44); dHoursT.7mapSegment(_7SEG_SEG_C, 54 , 55 , 56 , 57 , 58 , 59 , 60 , 61 , 62); dHoursT.1mapSegment(_7SEG_SEG_D, 8 , 7 , 6 , 5 , 4 , 3 , 2 , 1 , 0); dHoursT.2mapSegment(_7SEG_SEG_E, 17 , 16 , 15 , 14 , 13 , 12 , 11 , 10 , 9); dHoursT.3mapSegment(_7SEG_SEG_F, 26 , 25 , 24 , 23 , 22 , 21 , 20 , 19 , 18); dHoursT.6mapSegment(_7SEG_SEG_G, 53 , 52 , 51 , 50 , 49 , 48 , 47 , 46 , 45);

    // digit 2
    dHoursT.setShowZero(!hideZero);
    dHoursT.11mapSegment(_7SEG_SEG_A, 90 , 97 , 92 , 93 , 94, 95 , 96 , 97 , 98);
    dHoursT.12mapSegment(_7SEG_SEG_B, 99 , 100 , 101 , 102 , 103 , 104 , 105 , 106 , 107);
    dHoursT.14mapSegment(_7SEG_SEG_C, 117 , 118 , 119 , 120 , 121 , 122 , 123 , 124 , 125);
    dHoursT.8mapSegment(_7SEG_SEG_D, 71 , 70 , 69 , 68 , 67 , 66 , 65 , 64 , 63);
    dHoursT.9mapSegment(_7SEG_SEG_E, 80 , 79 , 78 , 77 , 76 , 75 , 74 , 73 , 72);
    dHoursT.10mapSegment(_7SEG_SEG_F, 89 , 88 , 87 , 86 , 85, 84 , 83 , 82 , 81);
    dHoursT.13mapSegment(_7SEG_SEG_G, 116 , 115 , 114 , 113 , 112 , 111 , 110 , 109 , 108);
   
    // addLed must be called LC_SEP_LEDS times
    sep.addLed(2, 0, 126);
    sep.addLed(4, 0, 127);
  
    // digit 3
    dHoursT.setShowZero(!hideZero);
    dHoursT.18mapSegment(_7SEG_SEG_A, 155 , 156 , 157 , 158 , 159, 160 , 161 , 162 , 163 );
    dHoursT.19mapSegment(_7SEG_SEG_B, 164 , 165 , 166 , 167 , 168 , 169 , 170 , 171 , 172 );
    dHoursT.21mapSegment(_7SEG_SEG_C, 182 , 183 , 184 , 185 , 186 , 187 , 188 , 189 , 190 );
    dHoursT.15mapSegment(_7SEG_SEG_D, 136 , 135 , 134 , 133 , 132 , 131 , 130 , 129 , 128 );
    dHoursT.16mapSegment(_7SEG_SEG_E, 145 , 144 , 143 , 142 , 141, 140 , 139 , 138 , 137 );
    dHoursT.17mapSegment(_7SEG_SEG_F, 154 , 153 , 152 , 151 , 150 , 149 , 148 , 147 , 146 );
    dHoursT.20mapSegment(_7SEG_SEG_G, 181 , 180 , 179 , 178 , 177 , 176 , 175 , 174 , 173 );
   
    // digit 4
    dHoursT.setShowZero(!hideZero);
    dHoursT.25mapSegment(_7SEG_SEG_A, 218 , 219 , 220 , 221 , 222, 223 , 224 , 225 , 226 );
    dHoursT.26mapSegment(_7SEG_SEG_B, 227 , 228 , 229 , 230 , 231 , 232 , 233 , 234 , 235 );
    dHoursT.28mapSegment(_7SEG_SEG_C, 245 , 246 , 247 , 248 , 249 , 250 , 251 , 252 , 253 );
    dHoursT.22mapSegment(_7SEG_SEG_D, 199 , 198 , 197 , 196 , 195, 194 , 193 , 192 , 191 );
    dHoursT.23mapSegment(_7SEG_SEG_E, 208 , 207 , 206 , 205 , 240 , 203 , 202 , 201 , 200 );
    dHoursT.24mapSegment(_7SEG_SEG_F, 217 , 216 , 215 , 214 , 213 , 212 , 211 , 210 , 209 );
    dHoursT.27mapSegment(_7SEG_SEG_G, 244 , 243 , 242 , 241 , 240 , 239 , 238 , 237 , 236 );

grazie mille

aldo-2000 avatar Jun 17 '23 00:06 aldo-2000

If you want to change how many LEDs make up a segment:

Problem: There is not the number "2" but "LC_LEDS_PER_SEGM" image

I modified the file "const_ledclock.h as follows: image

It does not work !!

  • currently it is not possible to change the number of LEDs in the separator

Either if you've changed the number of LEDs or just want to change the order of LEDs, you need to re-map the LEDs here:

  • For example the statement dHoursT.mapSegment(_7SEG_SEG_A, 6, 7); maps the 'A' segment of the 'tens' digit to LEDs indexed with 6 and 7.

  • mapSegment(...) can be called with variable number of arguments depending on how many LEDs you have per segment.

  • mapSegment(...) expects LED ordering within a segment:

    • left to right for horizontal segments (e.g. A)
    • top to bottom for vertical segments (e.g. B)

EDIT: about the mapping of the separator, read this.

Your configuration with 2 LEDs per segment works very well without anything on line 346 image

Can you help me please ? THANKS Francis

BoobixX avatar Sep 22 '23 14:09 BoobixX

ho provato a modificare il codice, ma non riesco a concludere il salvataggio, in quanto su VSC mi da un sempre errore. anche se il codice sorgente non viene modificato. da sempre errore * Invalid environment name 'codm-controller-0.6-rev2'. The name can contain alphanumeric, Screenshot 2023-10-13 235848 underscore, and hyphen characters (a-z, 0-9, -, _) mi potreste inviare il file inmaggine con la modifica dei numero dei led da 2 a 1 led per segmento?

`void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.mapSegment(_7SEG_SEG_A, 2); dHoursT.mapSegment(_7SEG_SEG_B, 1); dHoursT.mapSegment(_7SEG_SEG_C, 6); dHoursT.mapSegment(_7SEG_SEG_D, 5); dHoursT.mapSegment(_7SEG_SEG_E, 4); dHoursT.mapSegment(_7SEG_SEG_F, 3); dHoursT.mapSegment(_7SEG_SEG_G, 0);

// digit 2
dHoursO.mapSegment(_7SEG_SEG_A, 9);
dHoursO.mapSegment(_7SEG_SEG_B, 8);
dHoursO.mapSegment(_7SEG_SEG_C, 13);
dHoursO.mapSegment(_7SEG_SEG_D, 12);
dHoursO.mapSegment(_7SEG_SEG_E, 11);
dHoursO.mapSegment(_7SEG_SEG_F, 10);
dHoursO.mapSegment(_7SEG_SEG_G, 7);

sep.map(2,
    2, 0, 29,
    4, 0, 28);

// digit 3
dMinutesT.mapSegment(_7SEG_SEG_A, 18);
dMinutesT.mapSegment(_7SEG_SEG_B, 17);
dMinutesT.mapSegment(_7SEG_SEG_C, 22);
dMinutesT.mapSegment(_7SEG_SEG_D, 21);
dMinutesT.mapSegment(_7SEG_SEG_E, 20);
dMinutesT.mapSegment(_7SEG_SEG_F, 19);
dMinutesT.mapSegment(_7SEG_SEG_G, 16);

// digit 4
dMinutesO.mapSegment(_7SEG_SEG_A, 25);
dMinutesO.mapSegment(_7SEG_SEG_B, 24);
dMinutesO.mapSegment(_7SEG_SEG_C, 29);
dMinutesO.mapSegment(_7SEG_SEG_D, 28);
dMinutesO.mapSegment(_7SEG_SEG_E, 27);
dMinutesO.mapSegment(_7SEG_SEG_F, 26);
dMinutesO.mapSegment(_7SEG_SEG_G, 23);`

cocolino83 avatar Oct 14 '23 19:10 cocolino83

ho provato a modificare il codice, ma non riesco a concludere il salvataggio, in quanto su VSC mi da un sempre errore. anche se il codice sorgente non viene modificato. da sempre errore * Invalid environment name 'codm-controller-0.6-rev2'. The name can contain alphanumeric, Screenshot 2023-10-13 235848 underscore, and hyphen characters (a-z, 0-9, -, _) mi potreste inviare il file inmaggine con la modifica dei numero dei led da 2 a 1 led per segmento?

`void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.mapSegment(_7SEG_SEG_A, 2); dHoursT.mapSegment(_7SEG_SEG_B, 1); dHoursT.mapSegment(_7SEG_SEG_C, 6); dHoursT.mapSegment(_7SEG_SEG_D, 5); dHoursT.mapSegment(_7SEG_SEG_E, 4); dHoursT.mapSegment(_7SEG_SEG_F, 3); dHoursT.mapSegment(_7SEG_SEG_G, 0);

// digit 2
dHoursO.mapSegment(_7SEG_SEG_A, 9);
dHoursO.mapSegment(_7SEG_SEG_B, 8);
dHoursO.mapSegment(_7SEG_SEG_C, 13);
dHoursO.mapSegment(_7SEG_SEG_D, 12);
dHoursO.mapSegment(_7SEG_SEG_E, 11);
dHoursO.mapSegment(_7SEG_SEG_F, 10);
dHoursO.mapSegment(_7SEG_SEG_G, 7);

sep.map(2,
    2, 0, 29,
    4, 0, 28);

// digit 3
dMinutesT.mapSegment(_7SEG_SEG_A, 18);
dMinutesT.mapSegment(_7SEG_SEG_B, 17);
dMinutesT.mapSegment(_7SEG_SEG_C, 22);
dMinutesT.mapSegment(_7SEG_SEG_D, 21);
dMinutesT.mapSegment(_7SEG_SEG_E, 20);
dMinutesT.mapSegment(_7SEG_SEG_F, 19);
dMinutesT.mapSegment(_7SEG_SEG_G, 16);

// digit 4
dMinutesO.mapSegment(_7SEG_SEG_A, 25);
dMinutesO.mapSegment(_7SEG_SEG_B, 24);
dMinutesO.mapSegment(_7SEG_SEG_C, 29);
dMinutesO.mapSegment(_7SEG_SEG_D, 28);
dMinutesO.mapSegment(_7SEG_SEG_E, 27);
dMinutesO.mapSegment(_7SEG_SEG_F, 26);
dMinutesO.mapSegment(_7SEG_SEG_G, 23);`

Hi, you can replace - with _ in lines 605 and 614. Compilation will be possible but I don't know the impact in the program. If a charitable soul would like to respond to my post above for the number of LEDs Thanks

Francois

BoobixX avatar Oct 18 '23 16:10 BoobixX

I want to do the same…9 LEDs per segment Do you have a solution ?

Hi, I built the 4-display clock with 7 segments and two separators, each segment has 9 LEDs, I tried to change the parameters as you showed in the example, but I couldn't get anything done. this is what i wrote: void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.4mapSegment(_7SEG_SEG_A, 27 , 28 , 29 , 30 , 31 , 32 , 33 , 34 , 35); dHoursT.5mapSegment(_7SEG_SEG_B, 36 , 37 , 38 , 39 , 40 , 41 , 42 , 43 , 44); dHoursT.7mapSegment(_7SEG_SEG_C, 54 , 55 , 56 , 57 , 58 , 59 , 60 , 61 , 62); dHoursT.1mapSegment(_7SEG_SEG_D, 8 , 7 , 6 , 5 , 4 , 3 , 2 , 1 , 0); dHoursT.2mapSegment(_7SEG_SEG_E, 17 , 16 , 15 , 14 , 13 , 12 , 11 , 10 , 9); dHoursT.3mapSegment(_7SEG_SEG_F, 26 , 25 , 24 , 23 , 22 , 21 , 20 , 19 , 18); dHoursT.6mapSegment(_7SEG_SEG_G, 53 , 52 , 51 , 50 , 49 , 48 , 47 , 46 , 45);

    // digit 2
    dHoursT.setShowZero(!hideZero);
    dHoursT.11mapSegment(_7SEG_SEG_A, 90 , 97 , 92 , 93 , 94, 95 , 96 , 97 , 98);
    dHoursT.12mapSegment(_7SEG_SEG_B, 99 , 100 , 101 , 102 , 103 , 104 , 105 , 106 , 107);
    dHoursT.14mapSegment(_7SEG_SEG_C, 117 , 118 , 119 , 120 , 121 , 122 , 123 , 124 , 125);
    dHoursT.8mapSegment(_7SEG_SEG_D, 71 , 70 , 69 , 68 , 67 , 66 , 65 , 64 , 63);
    dHoursT.9mapSegment(_7SEG_SEG_E, 80 , 79 , 78 , 77 , 76 , 75 , 74 , 73 , 72);
    dHoursT.10mapSegment(_7SEG_SEG_F, 89 , 88 , 87 , 86 , 85, 84 , 83 , 82 , 81);
    dHoursT.13mapSegment(_7SEG_SEG_G, 116 , 115 , 114 , 113 , 112 , 111 , 110 , 109 , 108);
   
    // addLed must be called LC_SEP_LEDS times
    sep.addLed(2, 0, 126);
    sep.addLed(4, 0, 127);
  
    // digit 3
    dHoursT.setShowZero(!hideZero);
    dHoursT.18mapSegment(_7SEG_SEG_A, 155 , 156 , 157 , 158 , 159, 160 , 161 , 162 , 163 );
    dHoursT.19mapSegment(_7SEG_SEG_B, 164 , 165 , 166 , 167 , 168 , 169 , 170 , 171 , 172 );
    dHoursT.21mapSegment(_7SEG_SEG_C, 182 , 183 , 184 , 185 , 186 , 187 , 188 , 189 , 190 );
    dHoursT.15mapSegment(_7SEG_SEG_D, 136 , 135 , 134 , 133 , 132 , 131 , 130 , 129 , 128 );
    dHoursT.16mapSegment(_7SEG_SEG_E, 145 , 144 , 143 , 142 , 141, 140 , 139 , 138 , 137 );
    dHoursT.17mapSegment(_7SEG_SEG_F, 154 , 153 , 152 , 151 , 150 , 149 , 148 , 147 , 146 );
    dHoursT.20mapSegment(_7SEG_SEG_G, 181 , 180 , 179 , 178 , 177 , 176 , 175 , 174 , 173 );
   
    // digit 4
    dHoursT.setShowZero(!hideZero);
    dHoursT.25mapSegment(_7SEG_SEG_A, 218 , 219 , 220 , 221 , 222, 223 , 224 , 225 , 226 );
    dHoursT.26mapSegment(_7SEG_SEG_B, 227 , 228 , 229 , 230 , 231 , 232 , 233 , 234 , 235 );
    dHoursT.28mapSegment(_7SEG_SEG_C, 245 , 246 , 247 , 248 , 249 , 250 , 251 , 252 , 253 );
    dHoursT.22mapSegment(_7SEG_SEG_D, 199 , 198 , 197 , 196 , 195, 194 , 193 , 192 , 191 );
    dHoursT.23mapSegment(_7SEG_SEG_E, 208 , 207 , 206 , 205 , 240 , 203 , 202 , 201 , 200 );
    dHoursT.24mapSegment(_7SEG_SEG_F, 217 , 216 , 215 , 214 , 213 , 212 , 211 , 210 , 209 );
    dHoursT.27mapSegment(_7SEG_SEG_G, 244 , 243 , 242 , 241 , 240 , 239 , 238 , 237 , 236 );

grazie mille

I think there shouldnt be any space between the number and comma like - dHoursT.11mapSegment(_7SEG_SEG_A, 90, 97, 92, 93, 94, 95, 96, 97, 98);

i may be wrong . but try .

loverboyritesh avatar Oct 20 '23 10:10 loverboyritesh

Hello, is this solution for using a different number of LEDs still up to date?

I cloned the repo in VS an wanted to implement the changes for using 3 LEDs, but there are some completely different files and the part where the order of the LEDs is written, is not there at all. So then I downloaded the zip file and here everything looks like described. Which version should I use now?

And second question, can someone explain to me, how to properly build the program using VS and PlatformIO? This is my first project and I don't know what I'm doing wrong. I load the ledclock folder in VS Studio, then I click PlatformIO:build and afterwards PlatformIO:Upload which both work. But if I change for example the LED Pin inside the platformio_override.ini file, nothing happens and it still uses Pin 4 like before.

Thank you for helping and kind regards, Lucky

lucky-julie99 avatar Dec 22 '23 10:12 lucky-julie99

Hi there! The top of the main branch contains experimental code migrated to the latest WLED release. Very soon I'm planning to release another version of the firmware (as soon is blocking issues are fixed in WLED). That is why you're seeing different files, there were some big refactorings on the WLED side and I needed to adapt my code.

You can however use the latest stable release to apply your changes as described in this issue. In your repo, create a new branch on tag ledclock-1.2.0.

I hope this helps!

imeszaros avatar Dec 22 '23 10:12 imeszaros

Hi, thank you very much for that fast response :)

With the 1.2.0 I can open the project in VS, build and upload it with PlatformIO and it runs (but without the Wi-Fi even though it is configured) . And when I change the LED Port in platformio_override.ini, build and upload again, nothing changes. It still uses PIN 4 like before. The PIN isn't that important, it is just to see if the change works. But I need to set se DEFAULT_LED_COUNT to 86, which therefor also doesn't work. I looks like the changes I make in platform_override.ini and the other header files are not used in the build and I really can't figure out why. I never worked with PlatformIO or ESP32 programming before, so hopefully you can help me, if I do something completely wrong.

lucky-julie99 avatar Dec 22 '23 17:12 lucky-julie99

I'm glad building and upload works! :) In theory changing those defines in platformio_override.ini should do the trick.. But those are really just default values. When WLED boots for the first time, it will create a configuration file which will contain the LED settings, changing the defaults afterwards won't make a difference.

Try to erase the ESP32 flash storage and upload it again to see what settings it will initialize with. image

imeszaros avatar Dec 22 '23 22:12 imeszaros

Thank you very much, that worked. Really nice project :)

lucky-julie99 avatar Dec 29 '23 08:12 lucky-julie99

ho provato a modificare il codice, ma non riesco a concludere il salvataggio, in quanto su VSC mi da un sempre errore. anche se il codice sorgente non viene modificato. da sempre errore * Invalid environment name 'codm-controller-0.6-rev2'. The name can contain alphanumeric, Screenshot 2023-10-13 235848 underscore, and hyphen characters (a-z, 0-9, -, _) mi potreste inviare il file inmaggine con la modifica dei numero dei led da 2 a 1 led per segmento? `void setup() { // digit 1 dHoursT.setShowZero(!hideZero); dHoursT.mapSegment(_7SEG_SEG_A, 2); dHoursT.mapSegment(_7SEG_SEG_B, 1); dHoursT.mapSegment(_7SEG_SEG_C, 6); dHoursT.mapSegment(_7SEG_SEG_D, 5); dHoursT.mapSegment(_7SEG_SEG_E, 4); dHoursT.mapSegment(_7SEG_SEG_F, 3); dHoursT.mapSegment(_7SEG_SEG_G, 0);

// digit 2
dHoursO.mapSegment(_7SEG_SEG_A, 9);
dHoursO.mapSegment(_7SEG_SEG_B, 8);
dHoursO.mapSegment(_7SEG_SEG_C, 13);
dHoursO.mapSegment(_7SEG_SEG_D, 12);
dHoursO.mapSegment(_7SEG_SEG_E, 11);
dHoursO.mapSegment(_7SEG_SEG_F, 10);
dHoursO.mapSegment(_7SEG_SEG_G, 7);

sep.map(2,
    2, 0, 29,
    4, 0, 28);

// digit 3
dMinutesT.mapSegment(_7SEG_SEG_A, 18);
dMinutesT.mapSegment(_7SEG_SEG_B, 17);
dMinutesT.mapSegment(_7SEG_SEG_C, 22);
dMinutesT.mapSegment(_7SEG_SEG_D, 21);
dMinutesT.mapSegment(_7SEG_SEG_E, 20);
dMinutesT.mapSegment(_7SEG_SEG_F, 19);
dMinutesT.mapSegment(_7SEG_SEG_G, 16);

// digit 4
dMinutesO.mapSegment(_7SEG_SEG_A, 25);
dMinutesO.mapSegment(_7SEG_SEG_B, 24);
dMinutesO.mapSegment(_7SEG_SEG_C, 29);
dMinutesO.mapSegment(_7SEG_SEG_D, 28);
dMinutesO.mapSegment(_7SEG_SEG_E, 27);
dMinutesO.mapSegment(_7SEG_SEG_F, 26);
dMinutesO.mapSegment(_7SEG_SEG_G, 23);`

Hi, you can replace - with _ in lines 605 and 614. Compilation will be possible but I don't know the impact in the program. If a charitable soul would like to respond to my post above for the number of LEDs Thanks

Francois

Hi, i have replace [env:codm_ontroller_0.6] and [env:codm_controller_0.6_rev2] to . with _ in lines 605 and 614. to work properly.

TechHamara avatar Jan 07 '24 02:01 TechHamara

hi imeszaros can i build for esp8266 board. if possible then how can i build. i will but only esp32 release.

TechHamara avatar Jan 07 '24 02:01 TechHamara

hi imeszaros can i build for esp8266 board. if possible then how can i build. i will but only esp32 release.

ESP8266 is not supported by this project.

imeszaros avatar Jan 31 '24 13:01 imeszaros

Hi, i am completely new to esp32 and all of its stuff. I installed this project on esp, but i have just 1 led diode for each segment. I already changed and configured files for led positioning as you described, but now i do not know how to save all these files to format which i could put to esp32. Thank you.

tadejp12 avatar Jan 31 '24 16:01 tadejp12

HI. I downloaded the new update. I've tried and tried but I can't get my watch to work properly. I modified the code for 1 segment led, but I don't understand where I'm wrong in the code. I'm sending you my images hoping you can give me a hand. thanks 1000 in advance Screenshot 2024-02-01 020417 Screenshot 2024-02-01 020517 Screenshot 2024-02-01 020547 photo_2024-02-01_02-08-43 photo_2024-02-01_02-09-00

cocolino83 avatar Feb 01 '24 01:02 cocolino83

Hi @cocolino83 ,

your LC_LEDMAP looks good already.

You need to change LC_SEP_LED_ROWS to 1, 3 since your separator LEDs are in rows 1 and 3 instead of 2 and 4 (row numbers starting from zero!).

Additionally, as the compiler says, you need to change DEFAULT_LED_COUNT in platformoi_override.ini to 65.

Compile and upload, and do a factory reset in WLED to erase the existing LED settings and apply the new ones.

imeszaros avatar Feb 01 '24 07:02 imeszaros

Hi, i am completely new to esp32 and all of its stuff. I installed this project on esp, but i have just 1 led diode for each segment. I already changed and configured files for led positioning as you described, but now i do not know how to save all these files to format which i could put to esp32. Thank you.

Hi, you need to open the project in VSCode / PlatformIO and compile it. You can also use it to upload the code to the ESP32. Look for PlatformIO tutorials if you're new to it.

imeszaros avatar Feb 01 '24 08:02 imeszaros

CIAO@cocolino83,

stai LC_LEDMAPgià bene.

È necessario passare LC_SEP_LED_ROWSa 1, 3poiché i LED separatori si trovano nelle righe 1 e 3 anziché in 2 e 4 (numeri di riga che iniziano da zero!).

Inoltre, come dice il compilatore, è necessario passare DEFAULT_LED_COUNTa .platformoi_override.ini``65

Compila e carica ed esegui un ripristino delle impostazioni di fabbrica in WLED per cancellare le impostazioni LED esistenti e applicare quelle nuove.

thank you 1000 everything went well. photo_2024-02-01_10-31-37

I INSERT THE LINK FOR THE FILE.BIN 1 ONLY LED EACH SEGMENT. I BELIEVE IT MAY BE USEFUL TO OTHERS. https://github.com/cocolino83/Ledclook-1.3.0

cocolino83 avatar Feb 01 '24 09:02 cocolino83

Hello Y'all. Im new to all this. trying to add/chang led count. I understand how to do that. but to get to the road to change that's on my esp 32 is where I'm lost. I have wled clock running and on a led strip to test. like I sed I'm completly new. just need some guidence thanks

Nerdish22 avatar Feb 05 '24 00:02 Nerdish22

Ciao a tutti. Sono nuovo a tutto questo. cercando di aggiungere/modificare il conteggio dei led. Capisco come farlo. ma per arrivare alla strada del cambiamento che è sul mio ESP 32 è dove mi sono perso. Ho controllato l'orologio in funzione e ho testato una striscia LED. come se fossi completamente nuovo. ho solo bisogno di qualche dritta, grazie

Quanti led per segmento?

cocolino83 avatar Feb 05 '24 00:02 cocolino83

going to go from 2 led per seg to 5. I understand on what he's telling me to do. just not how to get the coat and to upload it

Nerdish22 avatar Feb 05 '24 00:02 Nerdish22

passerò da 2 led per seg a 5. Ho capito cosa mi dice di fare. semplicemente non come prendere il cappotto e caricarlo

Quindi devi solo caricare il firmware.bin e già configurato per due led per segmento. Per caricarlo su esp32 ti occorre il tool. Prova con questo. https://github.com/hanhdt/esp32-flash-tool

cocolino83 avatar Feb 05 '24 00:02 cocolino83

passerò da 2 led per seg a 5. Ho capito cosa mi dice di fare. semplicemente non come prendere il cappotto e caricarlo

Quindi devi solo caricare il firmware.bin e già configurato per due led per segmento. Per caricarlo su esp32 ti occorre il tool. Prova con questo. https://github.com/hanhdt/esp32-flash-tool

where do I get the bin from? do I download the hole Zip and get to it that way or copy past I'm more of a hands on guy

Nerdish22 avatar Feb 05 '24 00:02 Nerdish22

passerò da 2 led per seg a 5. Ho capito cosa mi dice di fare. semplicemente non come prendere il cappotto e caricarlo

Quindi devi solo caricare il firmware.bin e già configurato per due led per segmento. Per caricarlo su esp32 ti occorre il tool. Prova con questo. https://github.com/hanhdt/esp32-flash-tool

da dove prendo il cestino? faccio a scaricare il buco Zip e ad arrivarci in quel modo o lo copio? Sono più un tipo pratico

Non devi scaricare il file zip ma firmware.bin , una volta scaricato apri il tool per flash esp collegarlo il tuo esp 32 e al PC e installalo. Comunque ti consiglio di guardare su YouTube " wled esp32" 👍

cocolino83 avatar Feb 05 '24 01:02 cocolino83

passerò da 2 led per seg a 5. Ho capito cosa mi dice di fare. semplicemente non come prendere il cappotto e caricarlo

Quindi devi solo caricare il firmware.bin e già configurato per due led per segmento. Per caricarlo su esp32 ti occorre il tool. Prova con questo. https://github.com/hanhdt/esp32-flash-tool

da dove prendo il cestino? faccio a scaricare il buco Zip e ad arrivarci in quel modo o lo copio? Sono più un tipo pratico

Non devi scaricare il file zip ma firmware.bin , una volta scaricato apri il tool per flash esp collegarlo il tuo esp 32 e al PC e installalo. Comunque ti consiglio di guardare su YouTube " wled esp32" 👍

Thanks I'm doing it right now. hope it helps me out

Nerdish22 avatar Feb 05 '24 01:02 Nerdish22

Hello, I don't know anything about programming, barely understand Platformio but I wanted to change the number of LEDs from 2 to 3 per segment in version 1.3.0 So according to the instructions I change in const_ledclock.h LC_LEDS_PER_SEGM 3, change the entire matrix accordingly, then correct the position of LC_SEP_LED_ROWS 3, 5 and enter -D DEFAULT_LED_COUNT=189 in platformio_override.ini It seems to me that there is nothing else to set, but when compiling it shows me errors:

Compiling .pio\build\esp32dev\libd91\FS\FS.cpp.o In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/set.cpp:1: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ wled00/set.cpp: In function 'void handleSettingsSet(AsyncWebServerRequest*, byte)': wled00/set.cpp:720:103: error: 'dynamic_cast' not permitted with -fno-rtti LedClockSettings* settings = dynamic_cast<LedClockSettings *>(usermods.lookup(USERMOD_ID_LEDCLOCK)); ^ *** [.pio\build\esp32dev\src\set.cpp.o] Error 1 In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/wled.cpp:2: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ In file included from wled00/const.h:4:0, from wled00/wled.h:176, from C:/Users/jtp/Downloads/ledclock-ledclock-1.3.0/ledclock-ledclock-1.3.0/wled00/wled00.ino:13: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/wled_serial.cpp:1: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/ws.cpp:1: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/xml.cpp:1: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ In file included from wled00/const.h:4:0, from wled00/wled.h:176, from wled00/wled_server.cpp:1: wled00/const_ledclock.h:100:136: note: #pragma message: Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: ((((3 + 2) * 4) + 1) * ((3 * 2) + 3)) #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS)

^ wled00/const_ledclock.h:99:20: note: in definition of macro 'LC_STR' #define LC_STR(x) #x ^ wled00/const_ledclock.h:100:115: note: in expansion of macro 'LC_XSTR' #pragma message "Macro DEFAULT_LED_COUNT is not defined or is not equal to the calculated number of total LEDs: " LC_XSTR(LC_TOTAL_LEDS) ^ wled00/xml.cpp: In function 'void getSettingsJS(byte, char*)': wled00/xml.cpp:770:103: error: 'dynamic_cast' not permitted with -fno-rtti LedClockSettings* settings = dynamic_cast<LedClockSettings *>(usermods.lookup(USERMOD_ID_LEDCLOCK)); ^ *** [.pio\build\esp32dev\src\xml.cpp.o] Error 1 ===================================================== [FAILED] Took 15.97 seconds

Can I ask you to explain where I made a mistake ?

JureqB avatar Feb 07 '24 13:02 JureqB