vue-axios icon indicating copy to clipboard operation
vue-axios copied to clipboard

Type definition for TypeScript incorrectly augments "this"

Open Burtsev-Alexey opened this issue 1 year ago • 3 comments

Cleans up other projects augmentations as discussed in Vue official doc:

https://vuejs.org/guide/typescript/options-api.html#augmenting-custom-options

Breaks other projects, see: https://github.com/primefaces/primevue/issues/6624

This should be declare module ''vue' according to Vue doc (see first link) https://github.com/imcvampire/vue-axios/blob/990cacb197c3943c236725b82ebb8a94ac11dce2/index.d.ts#L5

Burtsev-Alexey avatar Oct 23 '24 08:10 Burtsev-Alexey

Thank you for the information. Will the change break be backward compatible with previous Vue version?

imcvampire avatar Oct 23 '24 14:10 imcvampire

Thank you for the information. Will the change break be backward compatible with previous Vue version?

I don't know. I have started developing for Vue only a few weeks ago. I'm just learning

Burtsev-Alexey avatar Oct 23 '24 18:10 Burtsev-Alexey

In this case, we can safely bump a major version

imcvampire avatar Oct 24 '24 05:10 imcvampire